Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch pin update] 951c21d6 - Inductor tests are starting to fail after pybind11 update to 2.13.6 #2260

Closed
pbchekin opened this issue Sep 16, 2024 · 9 comments · Fixed by #2271
Assignees

Comments

@pbchekin
Copy link
Contributor

PyTorch commit id: 951c21d6790334d57862e94a3f582ac724147a53
https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/10879914823/job/30185587514

_________ KernelTests.test_layout_constraint_needs_fixed_stride_order __________
Traceback (most recent call last):
  File "/runner/_work/intel-xpu-backend-for-triton/intel-xpu-backend-for-triton/pytorch/test/inductor/test_triton_kernels.py", line 1072, in test_layout_constraint_needs_fixed_stride_order
    eager_out = f(x)
  File "/runner/_work/intel-xpu-backend-for-triton/intel-xpu-backend-for-triton/pytorch/test/inductor/test_triton_kernels.py", line 1068, in f
    arange_out(x, y)
  File "/runner/_work/intel-xpu-backend-for-triton/intel-xpu-backend-for-triton/pytorch/test/inductor/test_triton_kernels.py", line 1059, in arange_out
    kernel[grid](x, out, n_elements, BLOCK_SIZE=4)
  File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/triton/runtime/jit.py", line 330, in <lambda>
    return lambda *args, **kwargs: self.run(grid=grid, warmup=False, *args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/triton/runtime/jit.py", line 657, in run
    kernel = self.compile(
  File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/triton/compiler/compiler.py", line 315, in compile
    metadata_group[metadata_filename] = fn_cache_manager.put(json.dumps(metadata, default=vars), metadata_filename,
  File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/json/__init__.py", line 234, in dumps
    return cls(
  File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/json/encoder.py", line 199, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/json/encoder.py", line 257, in iterencode
    return _iterencode(o, 0)
TypeError: vars() argument must have __dict__ attribute
@pbchekin
Copy link
Contributor Author

CC @alexbaden

@anmyachev
Copy link
Contributor

anmyachev commented Sep 17, 2024

Reducing the number of potential problems:

@anmyachev
Copy link
Contributor

For reference: pybind/pybind11#5377

@pbchekin
Copy link
Contributor Author

Do you think we can temporary pin pybind11 to the last working version?

@anmyachev
Copy link
Contributor

Do you think we can temporary pin pybind11 to the last working version?

This needs to be done on the PyTorch side by changing the version of pybind submodule, which can make a big difference from what they will use. So I'm not sure that's an option.

@vlad-penkin vlad-penkin reopened this Sep 20, 2024
@vlad-penkin vlad-penkin changed the title PyTorch inductor tests failed for 951c21d6 [PyTorch pin update] 951c21d6 - Inductor tests are starting to fail after pybind11 update to 2.13.6 Sep 20, 2024
@vlad-penkin
Copy link
Contributor

@alexbaden
Copy link
Contributor

pybind fix was merged last night/this morning, so this should also be resolved.

@vlad-penkin
Copy link
Contributor

We need to remove patch in our ci and local pytorch wheel builds before closing this ticket.

@anmyachev
Copy link
Contributor

Removed in #2351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants