Coverity fixes

IGC Coverity fixes

Author: amielcza

IGC/BiFModule/Languages/OpenCL/PreRelease/Matrix/IBiF_matrix_generator.cpp

@@ -62,7 +62,7 @@ static string ToStringAbove1(int number) {
 }
 
 // Replaces all occurrences of `toReplace` with `newText` in `source`
-static string Replace(string source, string toReplace, string newText) {
+static string Replace(string source, string toReplace, const string& newText) {
     size_t pos = 0;
     while((pos = source.find(toReplace, pos)) != std::string::npos) {
         source.replace(pos, toReplace.length(), newText);
@@ -914,8 +914,7 @@ static string ImplementLargeLoadBase(MatrixSpec spec, AddrSpace addr, int numLoa
     s = Replace(s, "WiRowsPerLoad", to_string(wiRowsPerLoad));
     s = Replace(s, "NumLoads", to_string(numLoads));
     s = Replace(s, "Rows", to_string(spec.Rows));
-    if (isChecked) s = Replace(s, "LoadArgs", "");
-    else           s = Replace(s, "LoadArgs", "");
+    s = Replace(s, "LoadArgs", "");
     return s;
 }
 

IGC/Compiler/Optimizer/OpenCLPasses/ManageableBarriers/ManageableBarriersResolution.hpp

@@ -71,7 +71,7 @@ namespace IGC
             llvm::Value* ConsumerCount;
         };
 
-        llvm::Module* mModule;
+        llvm::Module* mModule = nullptr;
         MBMode mCurrentMode;
 
         llvm::DenseMap<llvm::CallInst*, MBFuncType> mManageBarrierInstructions;

IGC/Compiler/Optimizer/WaveShuffleIndexSinking.cpp

@@ -339,7 +339,7 @@ namespace IGC
                         {
                             Instruction* lastAnchor = lastAnchorIdx == -1 ? cast<Instruction>(ShuffleOps[ i ]) : InstChains[ i ][ lastAnchorIdx ];
                             // operand to be replaced
-                            Instruction* rewirePrev = ( rewireIdx == 0 ) ? cast<Instruction>(ShuffleOps[ i ]) : InstChains[ i ][ rewireIdx - 1 ];
+                            Instruction* rewirePrev = InstChains[ i ][ rewireIdx - 1 ];
                             unsigned rewireOpIdx = InstChains[ i ][ rewireIdx ]->getOperand( 0 ) == rewirePrev ? 0 : 1;
                             InstChains[ i ][ rewireIdx ]->setOperand( rewireOpIdx, lastAnchor );
                             lastAnchorIdx = rewireIdx;