[tests] Enable MLIR C++ unittest with lit #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 9, 2024 10:18
|
This PR requires a new build of LLVM |
Menooker
changed the title
ZhennanQin
approved these changes
May 11, 2024
ciyongch
reviewed
May 11, 2024
test/gc-dialects/Unit/lit.cfg.py
Outdated
| @@ -0,0 +1,50 @@ | |||
| # -*- Python -*- | |||
There was a problem hiding this comment.
Maybe we don't need the multiple directories like gc-dialects to share the lit python files for other components like transforms/passes, runtime and others?
There was a problem hiding this comment.
The C++-based unittest is a special case. Filecheck tests don't need this lit config file.
added 3 commits
May 11, 2024 12:02
ciyongch
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example gtest unittest for MLIR and let it be driven by lit. The required cmake and lit configs are also added.