[Linalgx] Deprecate all linalgx matmul ops #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongshengDu
requested review from
zhczhong,
BRUCE11111,
huanghaixin008 and
Yun-Fly
|
Goal is to delete all linalgx matmul named ops code, please check for all usage. |
Yun-Fly
reviewed
Sep 9, 2024
| @@ -612,8 +612,7 @@ LogicalResult iterativelyFuseProducerAndConsumerOfTiledOp( | |||
|
|
|||
| /// This is a workaround to deal with LinalgXOp | |||
| static bool isTilableLinalgXOp(Operation *op) { | |||
| return isa<linalgx::BatchReduceMatmulVnniOp, linalgx::MultiBatchMatmulOp, | |||
| linalgx::Mm2DVnniOp, linalgx::Mm4DVnniOp>(op); | |||
| return linalgx::isAnyGenericPackedMatmulOp(op); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
If there exist no linalgX::matmul any more. Please help to remove isTilableLinalgXOp definition and its caller.
Yun-Fly
approved these changes
Sep 11, 2024
zhczhong
approved these changes
Sep 11, 2024
lmontigny
modified the milestones:
0.1 CPU - General,
0.1 CPU - Matmul functionnality support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete all linalgx matmul ops and switch to generic based ops.
Depend on #324