Introduce benchgc: a benchmark tool for correctness check #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangJialei-A
added
WIP
WangJialei-A
force-pushed
the
wangjial/benchgc_op
branch
19 times, most recently
from
3ffdb7d to
c398434
Compare
7 tasks
WangJialei-A
requested review from
leshikus,
Menooker,
kurapov-peter,
xurui1995 and
AshburnLee
WangJialei-A
force-pushed
the
wangjial/benchgc_op
branch
2 times, most recently
from
c3e4e4d to
25f9d5e
Compare
|
@leshikus @Menooker @xurui1995 @ZhennanQin @kurapov-peter You can check the correctness result here: Some of the OPs are not working and I raised a related issue #257 |
WangJialei-A
force-pushed
the
wangjial/benchgc_op
branch
2 times, most recently
from
c7e1e78 to
bb130aa
Compare
xurui1995
reviewed
Aug 19, 2024
WangJialei-A
force-pushed
the
wangjial/benchgc_op
branch
3 times, most recently
from
ff2821d to
c3b54ef
Compare
xurui1995
reviewed
Aug 20, 2024
WangJialei-A
force-pushed
the
wangjial/benchgc_op
branch
from
c3b54ef to
0a1edfc
Compare
WangJialei-A
force-pushed
the
wangjial/benchgc_op
branch
from
0a1edfc to
4167c5a
Compare
xurui1995
reviewed
Aug 21, 2024
|
|
||
| def get_constant_op( | ||
| self, ctx: gc_mlir.ir.Context, cst: Any | ||
| ) -> gc_mlir.dialects.tensor.OpView: |
There was a problem hiding this comment.
@xurui1995
What's the difference between them?
There was a problem hiding this comment.
they are the same, OpView is from the ir then tensor.py imported it
WangJialei-A
force-pushed
the
wangjial/benchgc_op
branch
4 times, most recently
from
279094c to
4772f9a
Compare
xurui1995
reviewed
Aug 26, 2024
|
The llvm revision is updated to include the needed fix from upstream. Please rebase and check the CI result. |
xurui1995
reviewed
Aug 26, 2024
WangJialei-A
force-pushed
the
wangjial/benchgc_op
branch
from
4772f9a to
b93e253
Compare
WangJialei-A
force-pushed
the
wangjial/benchgc_op
branch
from
b93e253 to
2cccd04
Compare
xurui1995
approved these changes
Aug 27, 2024
ZhennanQin
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #58
The single op test is demostrated at here
The Doc PR is #179