Skip to content

Commit 8500551

Browse files
author
Ivy Zhang
authored
Bug fix for correctness check (#258)
set unknown op as legal
1 parent 7d9b163 commit 8500551

File tree

2 files changed

+2
-23
lines changed

2 files changed

+2
-23
lines changed

lib/gc/ExecutionEngine/CPURuntime/MemoryPool.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -230,13 +230,6 @@ void FILOMemoryPool::release() {
230230
current = nullptr;
231231
}
232232

233-
void FILOMemoryPool::clear() {
234-
for (auto cur = current; cur; cur = cur->prev) {
235-
cur->allocated = sizeof(MemoryBlock);
236-
}
237-
current = buffers;
238-
}
239-
240233
FILOMemoryPool::~FILOMemoryPool() { release(); }
241234

242235
} // namespace

lib/gc/Transforms/MemRefToCPURuntime.cpp

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,8 @@
1212
#include "gc/Dialect/CPURuntime/IR/CPURuntimeDialect.h"
1313
#include "gc/Dialect/CPURuntime/IR/CPURuntimeOps.h"
1414
#include "gc/Transforms/Passes.h"
15-
#include "mlir/Dialect/Affine/IR/AffineOps.h"
1615
#include "mlir/Dialect/Bufferization/Transforms/BufferViewFlowAnalysis.h"
1716
#include "mlir/Dialect/Func/IR/FuncOps.h"
18-
#include "mlir/Dialect/LLVMIR/LLVMDialect.h"
19-
#include "mlir/Dialect/MemRef/IR/MemRef.h"
20-
#include "mlir/Dialect/SCF/IR/SCF.h"
21-
#include "mlir/IR/BuiltinDialect.h"
2217
#include "mlir/IR/PatternMatch.h"
2318
#include "mlir/Rewrite/FrozenRewritePatternSet.h"
2419
#include "mlir/Support/LogicalResult.h"
@@ -107,23 +102,14 @@ struct ConvertMemRefToCPURuntime
107102

108103
// add lowering target
109104
ConversionTarget target(getContext());
105+
// Make all operations legal by default.
106+
target.markUnknownOpDynamicallyLegal([](Operation *op) { return true; });
110107
target.addDynamicallyLegalOp<memref::AllocOp, memref::DeallocOp>(
111108
[&](Operation *op) {
112109
// Return true if the operation is in the noTransformOps set, making
113110
// it dynamically legal.
114111
return noTransformOps.find(op) != noTransformOps.end();
115112
});
116-
target.addLegalDialect<
117-
// clang-format off
118-
BuiltinDialect,
119-
func::FuncDialect,
120-
memref::MemRefDialect,
121-
cpuruntime::CPURuntimeDialect,
122-
arith::ArithDialect,
123-
affine::AffineDialect,
124-
scf::SCFDialect
125-
// clang-format on
126-
>();
127113
// set pattern
128114
RewritePatternSet patterns(ctx);
129115
patterns.add<AlignedAllocLowering>(ctx);

0 commit comments

Comments
 (0)