Skip to content

Device global copy kernel implementation #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Device global copy kernel implementation #65

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
22dd477
Device global implementation
sherry-yuan Jan 21, 2022
28d4a41
change kernel arg size to sizeof(void*)
sherry-yuan Jan 28, 2022
a8e4e24
temporarily remove release kernel
sherry-yuan Jan 28, 2022
7da91ae
avoid declaraing array with variable length as windows MSVC does not …
sherry-yuan Jan 28, 2022
b215103
fix klocwork issues
sherry-yuan Jan 28, 2022
819c180
Test both read and write device global
sherry-yuan Feb 4, 2022
51a15d1
use null to indicate optional clean up callback data
sherry-yuan Feb 7, 2022
ded9303
Per kernel autodiscovery change
sherry-yuan Feb 11, 2022
c767c31
Add device global in device autodiscovery definition
sherry-yuan Feb 12, 2022
5eb553a
Change autodiscovery format
sherry-yuan Mar 4, 2022
9716fab
Add clear functional documentation and line comments
sherry-yuan Mar 11, 2022
144020c
Fix klocwork and remove commented code.
sherry-yuan Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change kernel arg size to sizeof(void*)
  • Loading branch information
@sherry-yuan
sherry-yuan committed Mar 4, 2022
commit 28d4a4186a820e17fa247fca44efbf8d6cd72680
5 changes: 2 additions & 3 deletions test/acl_globals_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,9 @@ static acl_kernel_interface_t acltest_kernels[] = {
{// interface
"kernel15_dev_global",
{
{ACL_ARG_ADDR_GLOBAL, ACL_ARG_MEM_OBJ, sizeof(int *), 0, 0, 1},
{ACL_ARG_ADDR_GLOBAL, ACL_ARG_MEM_OBJ, sizeof(int *), 0, 0, 1},
{ACL_ARG_ADDR_GLOBAL, ACL_ARG_MEM_OBJ, sizeof(void *), 0, 0, 1},
{ACL_ARG_ADDR_GLOBAL, ACL_ARG_MEM_OBJ, sizeof(void *), 0, 0, 1},
{ACL_ARG_ADDR_NONE, ACL_ARG_BY_VALUE, sizeof(size_t), 0, 0},
// {ACL_ARG_ADDR_NONE, ACL_ARG_BY_VALUE, sizeof(size_t), 0, 0},
}}};

template <typename T, std::size_t N>
Expand Down