Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acl_hal_mmd clean up: purely cosmetic change #335

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

sophimao
Copy link
Contributor

No description provided.

@sophimao sophimao marked this pull request as ready for review December 19, 2023 16:50
@sophimao
Copy link
Contributor Author

Commits shall be merged post-review

@zibaiwan
Copy link
Contributor

Commits shall be merged post-review

Thanks Sophie for clean this up. I actually like the separate commits (you can merge the clang-format one into one of the commit). It was very clear to understand what you are changing only by reading the separate commits.

Copy link
Contributor

@zibaiwan zibaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sophie. I will re-approve if you want to merge the clang-format one into one of the commit.

@sophimao
Copy link
Contributor Author

sophimao commented Dec 19, 2023

you can merge the clang-format one into one of the commit

Ah okay, one thing with the commits is that I think the first commit doesn't compile on its own as I forgot to test in between commit 1 and commit 2 😢 Would it be okay if I combine commits 1 and 2, and leave commit 3+clang-format as a separate commit?

@zibaiwan
Copy link
Contributor

you can merge the clang-format one into one of the commit

Ah okay, one thing with the commits is that I think the first commit doesn't compile on its own as I forgot to test in between commit 1 and commit 2 😢 Would it be okay if I combine commits 1 and 2, and leave commit 3+clang-format as a separate commit?

Sure, sounds good!

@sophimao sophimao merged commit 1968efa into intel:main Dec 19, 2023
23 checks passed
@sophimao sophimao deleted the rt-cleanup branch December 19, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants