Check Delta Valgrind Logs #21
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Suppress false positives / noise 2. Remove memory address 3. Remove noise at beginning of each line 4. Display only what is added to the child valgrind report
…ge, need to remove after merge
|
Caveat: valgrind suppression is too specific, sometimes it filter out memcheck of type Addr2 (invalid read of size 2), but Addr1,4,8 might also happen for the same valgrind error. Next step: add additional script for duplicating Addr memcheck types so that it won't miss the same valgrind issue. |
|
This is potentially a no go given the suppression are noisy and the valgrind errors are not consistent across the runs. Push to 2022.4 for now. The better alternative is to fix all current valgrind issues, then apply this CI/CD. Will wait until its dependency are done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.