Skip to content

Conversation

@xin3he
Copy link
Contributor

@xin3he xin3he commented Sep 16, 2025

@xin3he xin3he requested a review from WeiweiZhang1 September 16, 2025 03:09
Copy link
Contributor

@WeiweiZhang1 WeiweiZhang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better add a UT for hpu auto device check, please confirm with Xuehao

@wenhuach21 wenhuach21 self-requested a review September 18, 2025 08:00
Copy link
Contributor

@yiliu30 yiliu30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xin3he xin3he force-pushed the xinhe/hpu branch 2 times, most recently from f114c1c to 4208196 Compare September 22, 2025 01:52
remove is_hpu_supported and refactor HPU UT

Signed-off-by: xinhe3 <xinhe3@habana.ai>
@wenhuach21
Copy link
Contributor

wenhuach21 commented Sep 22, 2025

LGTM

you could approve the pr

@wenhuach21
Copy link
Contributor

Xuehao reported an inference issue of HPU, is it related? If so, could you help fix it?

@wenhuach21 wenhuach21 merged commit 6e8732c into main Sep 23, 2025
7 of 8 checks passed
@wenhuach21 wenhuach21 deleted the xinhe/hpu branch September 23, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants