fixed the build routines

Author: guptask

cachelib/allocator/CMakeLists.txt

@@ -81,7 +81,6 @@ if (BUILD_TESTS)
     ${DATASTRUCT_TESTS_THRIFT_FILES}
     ./nvmcache/tests/NvmTestBase.cpp
     ./memory/tests/TestBase.cpp
-    ../common/TestUtils.cpp
     )
   add_dependencies(allocator_test_support thrift_generated_files)
   target_link_libraries (allocator_test_support PUBLIC

cachelib/benchmarks/CMakeLists.txt

@@ -17,7 +17,6 @@ add_thrift_file(DATATYPEBENCH DataTypeBench.thrift frozen2)
 if (BUILD_TESTS)
   add_library (benchmark_test_support
     ${DATATYPEBENCH_THRIFT_FILES}
-    ../common/TestUtils.cpp
     )
 
   add_dependencies(benchmark_test_support thrift_generated_files)

cachelib/common/CMakeLists.txt

@@ -47,19 +47,28 @@ install(TARGETS cachelib_common
 
 
 if (BUILD_TESTS)
-  add_library (common_test_support INTERFACE)
-  target_link_libraries (common_test_support INTERFACE
+  add_library (common_test_utils STATIC
+    TestUtils.cpp
+  )
+  target_link_libraries (common_test_utils PUBLIC
     cachelib_common
-    common_test_utils
     gflags
     GTest::gtest
     GTest::gtest_main
   )
-  target_sources(common_test_support INTERFACE
-    TestUtils.cpp
+
+  add_library (common_test_support OBJECT
     hothash/HotHashDetectorTest.cpp
     piecewise/GenericPiecesTest.cpp
-    piecewise/RequestRangeTest.cpp)
+    piecewise/RequestRangeTest.cpp
+  )
+  target_link_libraries (common_test_support PUBLIC
+    cachelib_common
+    common_test_utils
+    gflags
+    GTest::gtest
+    GTest::gtest_main
+  )
 
   function (ADD_TEST SOURCE_FILE)
      # Add any additional libraries BEFORE the "common_test_support" to ensure

cachelib/compact_cache/CMakeLists.txt

@@ -23,10 +23,9 @@ if (BUILD_TESTS)
     GTest::gtest
     GTest::gmock
   )
-  target_sources(compact_cache_test_support INTERFACE ../common/TestUtils.cpp)
 
   function (ADD_TEST SOURCE_FILE)
-     generic_add_test("compact-cache-test" "${SOURCE_FILE}"
+    generic_add_test("compact-cache-test" "${SOURCE_FILE}"
                       compact_cache_test_support "${ARGN}")
   endfunction()