Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Hashbrown 0.11 #346

Closed
haerdib opened this issue Aug 10, 2021 · 6 comments
Closed

Incompatibility with Hashbrown 0.11 #346

haerdib opened this issue Aug 10, 2021 · 6 comments

Comments

@haerdib
Copy link
Contributor

haerdib commented Aug 10, 2021

I'm facing the current problem while updating to substrate v4.0.0-dev:

sp-trie, which our enclave depends on, has been updated in v4.0.0:

mesalock has forked getrandom but only to v0.1, not v0.2

How should we proceed here?

@clangenb
Copy link
Contributor

clangenb commented Aug 10, 2021

I believe we need to fork getrandom v0.2 on our own and make it sgx-compatible.

Reason:

  • we can only patch crates if they have the same version number. I was unable to run cargo tree with the upgrade branch, but I believe, we can't get rid of it in the sgx-runtime. So, we need to patch it.

We can issue a PR-afterwards to getrandom-sgx, which might get included somewhen.

@haerdib haerdib changed the title Hashbrown 11.0 Incompatibility with Hashbrown 11.0 Aug 10, 2021
@brenzi
Copy link
Collaborator

brenzi commented Aug 10, 2021

Consider requesting a version update with teaclave/mesalock. They are very helpful and quick

@haerdib haerdib changed the title Incompatibility with Hashbrown 11.0 Incompatibility with Hashbrown 0.11 Aug 10, 2021
@haerdib haerdib linked a pull request Aug 11, 2021 that will close this issue
4 tasks
@haerdib haerdib removed a link to a pull request Aug 11, 2021
4 tasks
@haerdib
Copy link
Contributor Author

haerdib commented Aug 17, 2021

This issue is temporarily fixed with the local fork integritee-network/getrandom-sgx#1. But before closing this issue I would like to either have the tests of the PR pass or use an updated fork from teaclave. I'm still waiting for a response on apache/incubator-teaclave-sgx-sdk#350.

@brenzi
Copy link
Collaborator

brenzi commented Sep 7, 2021

status? @haerdib

@clangenb
Copy link
Contributor

clangenb commented Sep 7, 2021

I have checked @haerdib pr to upstream. She said she had some issues running the tests, which are blocking to make it work. However, this is only a rust-toolchain problem, I think. I could take a look at it and make sure the tests pass, such that nothing is in the way of the upstream merge.

@haerdib
Copy link
Contributor Author

haerdib commented Jun 23, 2022

I believe this issue is no longer necessary, as mesalock seems to be dead. So we need to maintain it ourselves anyway if we want to stay up to date.

@haerdib haerdib closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants