Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dependency format in Cargo.toml #329

Closed
clangenb opened this issue Aug 2, 2021 · 0 comments · Fixed by #347
Closed

Change dependency format in Cargo.toml #329

clangenb opened this issue Aug 2, 2021 · 0 comments · Fixed by #347
Assignees

Comments

@clangenb
Copy link
Contributor

clangenb commented Aug 2, 2021

We discussed the formatting of dependencies in Cargo.toml in In #328.

We came to the conclusion that the overall readability is improved if we use the one-line format compared to the multi-line.

E.g.
Good:

frame-metadata = { version = "13.0.0", default-features = false, git = "https://github.com/paritytech/substrate.git", branch = "master"}

bad:

[dependencies.sp-runtime]
git = "https://github.com/paritytech/substrate.git"
branch = "master"
version = "3.0.0"
default-features = false
@haerdib haerdib self-assigned this Aug 4, 2021
@haerdib haerdib linked a pull request Aug 11, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants