Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Cargo Update #319

Closed
haerdib opened this issue Jul 23, 2021 · 1 comment · Fixed by #347
Closed

Broken Cargo Update #319

haerdib opened this issue Jul 23, 2021 · 1 comment · Fixed by #347
Assignees

Comments

@haerdib
Copy link
Contributor

haerdib commented Jul 23, 2021

A general cargo update or a cargo update -p of substrate-api-client/sgx-runtime/my-node-runtime is currently not possible (see issue integritee-network/sgx-runtime#16).

There's a discussion ongoing about adding a release branch to substrate-api-client (scs/substrate-api-client#141). The question is now what we should do with the worker. In case of changes in the substrate-api-client (or the node or anything that depends on substrate) a cargo update is not possible and will stay impossible as long as substrate includes the version-dev.
If the substrate-api-client offers a release branch, the worker could switch to this branch, but we'd need to add this specific commit to all substrate dependencies within the .tomls..

I can't really see a good solution for this issue.. we have the option of eventual cargo update break intervals or readding commits to the toml..

Or is there a better solution?

@haerdib
Copy link
Contributor Author

haerdib commented Aug 3, 2021

We've decided to upgrade to substarte version 4.0.0-dev : paritytech/substrate@f651d45

@haerdib haerdib self-assigned this Aug 4, 2021
@haerdib haerdib linked a pull request Aug 11, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant