Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly verify grandpa justifications #1574

Open
brenzi opened this issue Jan 15, 2024 · 0 comments
Open

properly verify grandpa justifications #1574

brenzi opened this issue Jan 15, 2024 · 0 comments
Labels
F1-security possible vulnerability

Comments

@brenzi
Copy link
Collaborator

brenzi commented Jan 15, 2024

we had issues with the current implementations (#1547) and disabled the panic upon BadJustification (warning only) in #1573.

But we need to re-enable this check for full finality security
@brenzi brenzi added the F1-security possible vulnerability label Jan 15, 2024
This was referenced Jan 15, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F1-security possible vulnerability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brenzi