Add feature can_admins_bypass for repo environments | fixed wait_timer issue for repo environments #2001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kfcampbell
reviewed
Nov 10, 2023
kfcampbell
approved these changes
Nov 21, 2023
Contributor
kfcampbell
left a comment
kfcampbell
left a comment
There was a problem hiding this comment.
Thank you for the explanation, and for contributing!
1 task
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
…r issue for repo environments (integrations#2001) * fix environment wait timer so GitHub stays in line with terraform * add abilty to use can_admins_bypass for environment protections * update docs for repository environment can_admins_bypass * refactored wait_timer code as the logic was broken in a previous commit for this PR --------- Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For resource
github_repository_environmentResolves #1804
can_admins_bypassimplementedResolves #1996
wait_timerissue fixedBefore the change?
can_admins_bypasswas not implemented for repository environments.wait_timerwould not show a diff if updated outside of terraform.After the change?
can_admins_bypassis implemented.wait_timercorrectly shows a diff if updated outside of terraform.*
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!