-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inaccurate documentation for github_actions_public_key and github_actions_secret #406
Comments
hi @skoblenick @benj-fletch! i'm looking to begin implementing a change to address the discrepencies and it seems like there could be several ways to approach this including:
thoughts? happy to discuss other options you might of considered or anything I've missed, thanks! |
Hi @anGie44, thanks for picking this up and a comprehensive change detail! My thoughts on your proposed changes:
Since it is the least amount of work and reflects how the code currently works I think we should go with option (1). Any questions let me know 😄. Thanks! |
@benj-fletch thank you for the feedback! Option 1 it is :) |
Terraform Version
Terraform v0.12.24
Affected Resource(s)
Please list the resources as a list, for example:
Terraform Configuration Files
Code exactly like the sample in the current documentation:
Output
Expected Behavior
There shouldn't be
Error: Unsupported argument
on required argumentsActual Behavior
The errors above are output by the plan. If the "required" fields are moved the plan succeed correctly and can be applied. This works rather than the provided example:
Steps to Reproduce
terraform init
terraform plan -var-file="./my.tfvars" -out=plan.out
Important Factoids
This is a company GitHub account creating secrets on a private repository.
References
The text was updated successfully, but these errors were encountered: