Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: integrations/terraform-provider-github
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.15.0
Choose a base ref
...
head repository: integrations/terraform-provider-github
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.16.0
Choose a head ref
  • 4 commits
  • 8 files changed
  • 9 contributors

Commits on Jan 18, 2023

  1. Set LDAP DN on team creation (#1491)

    * Set LDAP DN on team creation
    
    fixes #1490 
    
    Set `LDAPDN` on the `NewTeam` on creation, if it's not the empty string. This avoids an extra call to the GHE API, but more importantly means the user does not need to be a site admin to create a team with LDAP sync
    
    * Fix linting?
    
    Co-authored-by: Keegan Campbell <me@kfcampbell.com>
    jMarkP and kfcampbell authored Jan 18, 2023
    Configuration menu
    Copy the full SHA
    8b93e4e View commit details
    Browse the repository at this point in the history
  2. Fixing github_repository_file owner/org handling (#1494)

    * Fixing `github_repository_file` owner handling, if `full_name` is
    passed, split it into `owner` and `repo`, use user as an `owner`
    otherwise
    
    Signed-off-by: Valery Masiutsin <val.masiutsin@gmail.com>
    
    * Update github/data_source_github_repository_file_test.go
    
    Co-authored-by: Keegan Campbell <me@kfcampbell.com>
    
    * Update website/docs/d/repository_file.html.markdown
    
    Co-authored-by: Keegan Campbell <me@kfcampbell.com>
    
    * Small docs fixup
    
    * Take into account @vmasutin's suggestion
    
    Signed-off-by: Valery Masiutsin <val.masiutsin@gmail.com>
    Co-authored-by: Keegan Campbell <me@kfcampbell.com>
    vmasutin and kfcampbell authored Jan 18, 2023
    Configuration menu
    Copy the full SHA
    592edcc View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. feature/985 branch protection checks (#1415)

    * feat: add new schema for check block resource under required_status_checks
    
    * feat: iterate provided `check` blocks and build array of RequiredStatusCheck
    
    * feat: set default app_id to -1
    
    * feat: implement checks flattening for required status checks
    
    * Add resource github_app_installation_repositories (#1376)
    
    * Add resource github_app_installation_repositories
    
    This resource allows multiple repositories to be passed in; which greatly improves the performance of the resource compared to the single repository version
    when needing to control state of multiple app installations with multiple repos, required in larger organisations.
    
    The optimisation occurs as only a single call to get the list of repos is required per installation per read, regardless of the number of respositories being added.
    
    - Add resource_github_app_installation_repositories
    - Add tests
    
    * Update docs and link
    
    Co-authored-by: Keegan Campbell <me@kfcampbell.com>
    
    * feat: adds new branch protection options for last reviewer and locking branch (#1407)
    
    Co-authored-by: Keegan Campbell <me@kfcampbell.com>
    
    * feat(github_release): adding github_release resource and tests (#1122)
    
    * feat(github_release): adding github_release resource and tests
    
    * feat(docs) adding github_release page to website docs
    
    * chore: update changelog with this pr's new resource
    
    * fix: adding node_id and release_id to resource attributes
    
    * Update CHANGELOG.md
    
    * Fix broken merge/build
    
    Co-authored-by: Keegan Campbell <me@kfcampbell.com>
    
    * 🚧 Workflows have changed
    
    Workflow changes have been made in the Octokit org repo. This PR is propagating those changes.
    
    * Issue template tweak (#1422)
    
    * Don't link to a real PR
    
    * Wording tweak
    
    * feat: allow branch protection check app_id to be null
    
    * chore: change branch protection flatten function to use GetAppID sdk method
    
    * feat: change branch protection v3 utils to flatten and expand contexts into checks
    
    * feat: change checks from it's own resource to a list of strings
    
    * chore: resolve incorrect merge of main
    
    * chore: update deprecation notice on contexts array
    
    * chore(docs): Update branch_protection_v3 docs to mention the new `checks` functionality
    
    * fix: Initialise literal empty slice of RequiredStatusCheck to mitigate errors when passing nil to the sdk
    
    * chore(lint): resolve gosimple S1082 violation (errors.New => fmt.Errorf)
    
    * chore: remove unused code comment
    
    Co-authored-by: David Bain <97858950+david-bain@users.noreply.github.com>
    Co-authored-by: Keegan Campbell <me@kfcampbell.com>
    Co-authored-by: Sean Smith <sean@wwsean08.com>
    Co-authored-by: Trent Millar <trent.millar@gmail.com>
    Co-authored-by: Nick Floyd <139819+nickfloyd@users.noreply.github.com>
    6 people authored Jan 20, 2023
    Configuration menu
    Copy the full SHA
    c5cfce0 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. [FIX]: Issue-1498 (#1500)

    Co-authored-by: Keegan Campbell <me@kfcampbell.com>
    pradeepbhadani and kfcampbell authored Jan 21, 2023
    Configuration menu
    Copy the full SHA
    543774c View commit details
    Browse the repository at this point in the history
Loading