Merge pull request rjancewicz#41 from michaelweiser/kadm5_init_null_deref

Prevent NULL pointer dereference if kadm5_init_with_creds fails

Author: rjancewicz

src/kadmin.c

@@ -309,14 +309,6 @@ static PyKAdminObject *_kadmin_init_with_ccache(PyObject *self, PyObject *args)
                 db_args, 
                 &kadmin->server_handle);
 
-    if (retval != KADM5_OK) { 
-
-        Py_XDECREF(kadmin);
-        kadmin = NULL;
-
-        PyKAdminError_raise_error(retval, "kadm5_init_with_creds");
-    }
-
 
 cleanup:
 
@@ -328,6 +320,14 @@ static PyKAdminObject *_kadmin_init_with_ccache(PyObject *self, PyObject *args)
     krb5_free_principal(kadmin->context, princ);
     krb5_cc_close(kadmin->context, cc);
 
+    if (retval != KADM5_OK) {
+
+        Py_XDECREF(kadmin);
+        kadmin = NULL;
+
+        PyKAdminError_raise_error(retval, "kadm5_init_with_creds");
+    }
+
     if (params)
         free(params);