Function name improvement + add configurable cron schedule + add comment for generated files location

Author: Bernard Delhez

src/Model/RewriteMapRepository.php

@@ -34,7 +34,7 @@ public function __construct(UrlRewriteCollectionFactory $rewriteCollectionFactor
      * @return RewriteMap
      * @throws InputException
      */
-    public function findByStoreAndType(int $storeId, int $redirectType): RewriteMap
+    public function getByStoreAndType(int $storeId, int $redirectType): RewriteMap
     {
         if (!in_array($redirectType, self::ALLOWED_REDIRECT_TYPES)) {
             throw new InputException(

src/Model/RewriteMapsSavingService.php

@@ -47,10 +47,10 @@ public function saveRewriteMapsForAllStores(): void
         foreach ($this->storeManager->getStores() as $store) {
             $storeId = (int)$store->getId();
             $this->saveRewriteMap(
-                $this->urlRewriteRepository->findByStoreAndType($storeId, UrlRewriteOptionProvider::PERMANENT)
+                $this->urlRewriteRepository->getByStoreAndType($storeId, UrlRewriteOptionProvider::PERMANENT)
             );
             $this->saveRewriteMap(
-                $this->urlRewriteRepository->findByStoreAndType($storeId, UrlRewriteOptionProvider::TEMPORARY)
+                $this->urlRewriteRepository->getByStoreAndType($storeId, UrlRewriteOptionProvider::TEMPORARY)
             );
         }
     }

src/etc/adminhtml/system.xml

@@ -6,8 +6,17 @@
 				<field id="rewrite_maps_generation_enabled" showInDefault="1" showInStore="1" showInWebsite="1"
                        sortOrder="500" translate="label" type="select">
 					<label>Enable Rewrite Maps Generation</label>
+					<comment>
+						<![CDATA[Enables the generation of rewrite maps files from the Magento UrlRewrites.
+						The files are saved under
+						path_to_magento/var/rewrite_map/map/rewrite-map-[REDIRECT_TYPE]-store-[STORE_ID].txt]]>
+					</comment>
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
 				</field>
+				<field id="rewrite_maps_generation_cron_schedule" showInDefault="1" showInStore="1" showInWebsite="1"
+					   sortOrder="510" translate="label" type="text">
+					<label>Rewrite Maps Generation Cron Schedule</label>
+				</field>
 			</group>
 		</section>
 	</system>

src/etc/config.xml

@@ -4,6 +4,7 @@
 		<catalog>
 			<seo>
 				<rewrite_maps_generation_enabled>0</rewrite_maps_generation_enabled>
+				<rewrite_maps_generation_cron_schedule>0 * * * *</rewrite_maps_generation_cron_schedule>
 			</seo>
 		</catalog>
 	</default>

src/etc/crontab.xml

@@ -3,7 +3,7 @@
 	<group id="default">
 		<job instance="IntegerNet\RewriteMap\Cron\GenerateRewriteMaps" method="execute"
              name="integernet_rewritemap_generaterewritemaps">
-			<schedule>0 * * * *</schedule>
+			<config_path>catalog/seo/rewrite_maps_generation_cron_schedule</config_path>
 		</job>
 	</group>
 </config>