Use and apply Magento coding standard

Author: schmengler

composer.json

@@ -43,5 +43,13 @@
         "phpstan/phpstan": "^0.12.0",
         "squizlabs/php_codesniffer": "^3.5",
         "magento/magento-coding-standard": "@dev"
+    },
+    "scripts": {
+        "post-install-cmd": [
+            "vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/"
+        ],
+        "post-update-cmd": [
+            "vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/"
+        ]
     }
 }

phpcs.xml

@@ -1,6 +1,5 @@
 <?xml version="1.0"?>
 <ruleset>
     <exclude-pattern>tests/</exclude-pattern>
-    <rule ref="PSR1"/>
-    <rule ref="PSR2"/>
+    <rule ref="Magento2"/>
 </ruleset>

src/Cron/GenerateRewriteMaps.php

@@ -27,8 +27,8 @@ class GenerateRewriteMaps
     public function __construct(
         RewriteMapsSavingService $rewriteMapsSavingService,
         LoggerInterface $logger,
-        ScopeConfigInterface $scopeConfig)
-    {
+        ScopeConfigInterface $scopeConfig
+    ) {
         $this->rewriteMapsSavingService = $rewriteMapsSavingService;
         $this->logger = $logger;
         $this->scopeConfig = $scopeConfig;

src/Model/RewriteMapRepository.php

@@ -39,9 +39,9 @@ public function getByStoreAndType(int $storeId, int $redirectType): RewriteMap
         if (!in_array($redirectType, self::ALLOWED_REDIRECT_TYPES)) {
             throw new InputException(
                 __(
-                    'The given redirect type "%1" is not a allowed type: %2',
+                    'The given redirect type "%1" is not an allowed type: [%2]',
                     $redirectType,
-                    print_r(self::ALLOWED_REDIRECT_TYPES, true)
+                    implode(',', self::ALLOWED_REDIRECT_TYPES)
                 )
             );
         }

src/Model/RewriteMapsSavingService.php

@@ -31,8 +31,8 @@ class RewriteMapsSavingService
     public function __construct(
         Filesystem $filesystem,
         StoreManagerInterface $storeManager,
-        RewriteMapRepository $urlRewriteRepository)
-    {
+        RewriteMapRepository $urlRewriteRepository
+    ) {
         $this->filesystem = $filesystem;
         $this->storeManager = $storeManager;
         $this->urlRewriteRepository = $urlRewriteRepository;