Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚩 PR: Added new Button Step action block #782

Merged
merged 2 commits into from
Jul 24, 2024
Merged

🚩 PR: Added new Button Step action block #782

merged 2 commits into from
Jul 24, 2024

Conversation

elsoazemelet
Copy link
Contributor

Closes #775

  • Added button step action block, that works with button mode (2-step, 3-step)
  • Additional steps can be added similiarly to if condition blocks
  • The displayed step name, and the code on grid should update dynamically, when steps are added/removed

Copy link
Contributor

github-actions bot commented Jul 21, 2024

Visit the preview URL for this PR (updated for commit 4788319):

https://grid-editor-web--pr782-feat-buttonstep-vse7auqv.web.app

(expires Tue, 30 Jul 2024 15:07:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@SukuWc
Copy link
Member

SukuWc commented Jul 22, 2024

Looks promising, only need couple of minor tweeks:

  • Add "Add Action" helper box similar to all other special action blocks
    image
  • Action picker menu should not recommend nesting of Button Step actions, please remove this option from the list when it it would cause nesting
    image
    image

@SukuWc SukuWc merged commit 9850598 into stable Jul 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement button step special actionblock
2 participants