Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚩PR: Fixed Copy/Paste for texts and fixed Icon display #725

Merged
merged 4 commits into from
May 17, 2024

Conversation

elsoazemelet
Copy link
Contributor

@elsoazemelet elsoazemelet commented May 14, 2024

Closes #724 and #716

  • Now copy/paste does not clash with monaco and line editor
  • Added fill property for SvgIcons. This is now defined through the code, where necessary.
  • Restored white fill for problematic SVG icons (see the original ticket of Arrows changed to black from white, Editor v1.2.53 #716)

Copy link
Contributor

github-actions bot commented May 14, 2024

Visit the preview URL for this PR (updated for commit 0d72b37):

https://grid-editor-web--pr725-bug-shortcut-edjlfxda.web.app

(expires Tue, 21 May 2024 16:02:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@elsoazemelet elsoazemelet changed the title 🚩PR: Fixed Copy/Paste for texts 🚩PR: Fixed Copy/Paste for texts and fixed Icon display May 14, 2024
@SukuWc SukuWc merged commit b4c407a into stable May 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot copy-paste into monaco editor due to new keyboard shortcut handling
2 participants