Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every button is now MoltenPushButton #605

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

elsoazemelet
Copy link
Contributor

All buttons are now using the component MoltenPushButton.
The design of all buttons are now unified with three introduced styles:

  • Normal: A black one, using the design language of Preferences
  • Accpet: A green one, that is useing the design of the store button
  • Outlined: A transparent one with green border, using the design of the troubleshoot button on the module connect dialog

Interesting features:

  • The action block operations (copy, paste, cut, etc.) buttons are now using this new MoltenPushButton as a base.
  • The confirm style tooltip used at the clear button to confirm the clear is using now this new MoltenPushButton.

Actions to do:

Review editor, and determine further advancements in design unification

@narayb
Copy link
Collaborator

narayb commented Feb 20, 2024

Pasted image 20240220155358
Visibility is still horrible in front of dark backgrounds.

Pasted image 20240220155839
They look okay when the background is lighter than the button background...

Pasted image 20240220155914
...but all that goes out the window when there is no light background.

All in all, the buttons look nice, but usability suffers with every change we make to these buttons without changing the contrast of either the backgrounds or the buttons or their borders.

Please use this now complete technology change to update the design and make the buttons pop from their backgrounds again.

@elsoazemelet elsoazemelet merged commit 6dc8bfe into stable Feb 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants