updated tests for acquisition description files using daqami sync mode

Author: grg2rsr

iblrig/neurophotometrics.py

@@ -256,9 +256,9 @@ def _validate_neurophotometrics_description(
         ix = [i for i, loc in enumerate(locations) if loc == location]
         assert len(ix) <= 2, 'there are only 2 possible bands'
         rois_per_loc = [rois[i] for i in ix]
-        # check that each band is present only once
-        assert sum(True for roi in rois_per_loc if roi.startswith('G')) == 1, 'duplicate green band'
-        assert sum(True for roi in rois_per_loc if roi.startswith('R')) == 1, 'duplicate red band'
+        # check that each band is present once or none
+        assert sum(True for roi in rois_per_loc if roi.startswith('G')) in [0, 1], 'duplicate green band'
+        assert sum(True for roi in rois_per_loc if roi.startswith('R')) in [0, 1], 'duplicate red band'
     assert sync_mode in ('bpod', 'daqami'), 'sync mode must be either bpod or daqami'
 
 
@@ -326,7 +326,6 @@ def neurophotometrics_description(
             sync_metadata:
                 acquisition_software: daqami
                 collection: raw_photometry_data
-                sampling_rate: 1000
                 frameclock_channel: 0
 
     """

iblrig/test/test_neurophotometrics.py

@@ -6,7 +6,10 @@
 
 class TestExperimentDescription(unittest.TestCase):
     def test_neurophotometrics_description(self):
+        # tests the generation of the acquisition description
         dt = datetime.datetime.fromisoformat('2024-10-11T11:11:00')
+
+        # for bpod based sync
         d = neurophotometrics_description(
             rois=['G0', 'G1'], locations=['SI', 'VTA'], sync_channel=1, start_time=dt, sync_mode='bpod'
         )
@@ -22,3 +25,25 @@ def test_neurophotometrics_description(self):
             }
         }
         self.assertEqual(dexpected, d)
+
+        # for daqami sync
+        d = neurophotometrics_description(
+            rois=['G0', 'G1'], locations=['SI', 'VTA'], sync_channel=1, start_time=dt, sync_mode='daqami'
+        )
+        dexpected = {
+            'devices': {
+                'neurophotometrics': {
+                    'sync_channel': 1,
+                    'datetime': '2024-10-11T11:11:00',
+                    'collection': 'raw_photometry_data',
+                    'fibers': {'G0': {'location': 'SI'}, 'G1': {'location': 'VTA'}},
+                    'sync_mode': 'daqami',
+                    'sync_metadata': {
+                        'acquisition_software': 'daqami',
+                        'collection': 'raw_photometry_data',
+                        'frameclock_channel': 0,
+                    },
+                }
+            }
+        }
+        self.assertEqual(dexpected, d)