avoid always updating migration advisory lock

it's stored as a string, not an integer

also avoid extra instantiations of InternalMetadata when we already have it available

Change-Id: Ib58953c90e6f22dfa81f2d6beaf6b8d0c7040026
Reviewed-on: https://gerrit.instructure.com/c/switchman/+/379550
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>

Author: ccutrer

lib/switchman/active_record/migration.rb

@@ -30,11 +30,9 @@ def generate_migrator_advisory_lock_id
         shard_name_hash = ::ActiveRecord::Migrator::MIGRATOR_SALT * db_name_hash
         # Store in internalmetadata to allow other tools to be able to lock out migrations
         if ::Rails.version < "7.1"
-          ::ActiveRecord::InternalMetadata[:migrator_advisory_lock_id] = shard_name_hash
-        elsif ::Rails.version < "7.2"
-          ::ActiveRecord::InternalMetadata.new(connection)[:migrator_advisory_lock_id] = shard_name_hash
+          ::ActiveRecord::InternalMetadata[:migrator_advisory_lock_id] = shard_name_hash.to_s
         else
-          ::ActiveRecord::InternalMetadata.new(connection.pool)[:migrator_advisory_lock_id] = shard_name_hash
+          @internal_metadata[:migrator_advisory_lock_id] = shard_name_hash.to_s
         end
         shard_name_hash
       end