Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce the types that are passed in from the CLI in main_ds and data_process #27

Open
RobotSail opened this issue Jun 17, 2024 · 1 comment
Open

Enforce the types that are passed in from the CLI in main_ds and data_process #27

RobotSail opened this issue Jun 17, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@RobotSail
Copy link
Member

Today the main_ds.py and data_process.py files parse out arguments
on the command-line via argparse. These parsed arguments are then
sent through the respective main functions and used as objects.

This should be updated so that there's type-checking happening to validate
that these types are truly present.
@ktam3
Copy link

ktam3 commented Jul 16, 2024

Is this done?

@nathan-weinberg nathan-weinberg added the enhancement New feature or request label Aug 20, 2024
@ktam3 ktam3 added the good first issue Good for newcomers label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nathan-weinberg @RobotSail @ktam3