Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DeepSpeed an optional requirement #250

Open
RobotSail opened this issue Oct 7, 2024 · 1 comment
Open

Make DeepSpeed an optional requirement #250

RobotSail opened this issue Oct 7, 2024 · 1 comment

Comments

@RobotSail
Copy link
Member

In main_ds.py and possibly other files, we import DeepSpeed at the top level regardless if it's installed or not. To make it truly optional, we should either make this an either a conditional or try/catch import, or just remove it entirely.
@Harthi7 Harthi7 mentioned this issue Oct 13, 2024
Closed
@Harthi7
Copy link
Contributor

Harthi7 commented Oct 13, 2024

Hello @RobotSail I made a PR for this issue #267 , Please let me know if I missed anything

@Harthi7 Harthi7 mentioned this issue Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Harthi7 @RobotSail