-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a dice toss skill #355
Conversation
adding a skill to toss a dice Signed-off-by: Shai Revivo <98468006+shairevivo@users.noreply.github.com>
Signed-off-by: Shai Revivo <98468006+shairevivo@users.noreply.github.com>
Updated 2 dice to dice and 1 dice to die. Signed-off-by: Shai Revivo <98468006+shairevivo@users.noreply.github.com>
Signed-off-by: Shai Revivo <98468006+shairevivo@users.noreply.github.com>
Signed-off-by: Shai Revivo <98468006+shairevivo@users.noreply.github.com>
Better generation and training results with this fine tuned file Signed-off-by: Shai Revivo <98468006+shairevivo@users.noreply.github.com>
fine tuned file with better training results Signed-off-by: Shai Revivo <98468006+shairevivo@users.noreply.github.com>
Updated with the source requirements. Signed-off-by: Shai Revivo <98468006+shairevivo@users.noreply.github.com>
fix trailing spaces Signed-off-by: Shai Revivo <98468006+shairevivo@users.noreply.github.com>
last fix (hopefully) Signed-off-by: Shai Revivo <98468006+shairevivo@users.noreply.github.com>
fixed last line for attribution Signed-off-by: Shai Revivo <98468006+shairevivo@users.noreply.github.com>
Can you please show some output on the original model? I'm not convinced the model needs improvement at this skill. If this is genuinely a deficit in the model, I'd suggest being able to respond to DnD style "roll 2d20" prompts as well. It's a cute skill and likely to work - if the improvement is actually needed. |
Signed-off-by: Shai Revivo <98468006+shairevivo@users.noreply.github.com>
Here is before and after output i captured:
After:
BTW, i improved the output a bit since this out put captured but it is obvious the original model is lacking. |
Thank you for your contribution to InstructLab! Unfortunately, once a Github repo is made public, all open PRs are automatically closed since they link against a private repo. We have detected that your PR might have been one of the ones affected by this change. If you are still interested in contributing your improvement, please fill out the following short form by no later than May 3rd, and we will get back to you with the additional steps necessary once we have had time to assess the PRs of those still interested: |
adding a skill to toss a dice
If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.
**I have added a skill to roll \ toss a dice (any number of dice) **
Added the ability to toss a dice, 2 dice and as many as needed.
The chat will return emoji of a dice and the result along with some details on stats \ sum etc.
Input given at the prompt
I added multiple possible questions for tossing a dice or number of dice.
Response that was received
output will be the number \ numbers along with
Example:
Response that is now received instead
Added above a screen shot that shows some input \ output on the trained model.
Contribution checklist
lab generate
lab generate
qna.yaml
file was linted and prettified (yaml-validator can do both)