Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phoenix Constellations (combined) #1159

Closed
wants to merge 1 commit into from
Closed

Phoenix Constellations (combined) #1159

wants to merge 1 commit into from

Conversation

jjasghar
Copy link
Member

@jjasghar jjasghar commented Jun 4, 2024

This is the combined Phoenix Constellations PRs from Red Hat Summit 2024.

This superseeds #899 #940 #947 #950 #980 #999 #1009 #1025 #1042 #1056

@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged knowledge (Auto labeled) labels Jun 4, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@jjasghar jjasghar force-pushed the jjasghar/phoenix branch 7 times, most recently from 1790f9e to a83fc68 Compare June 4, 2024 18:16
@jjasghar jjasghar added precheck-generate-ready PR is ready for precheck or generate step and removed triage-needed (Auto labeled) skill is ready to be triaged labels Jun 4, 2024
Copy link

Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instructlab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instructlab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instructlab-bot generate-local -- Generate a sample of synthetic data using a local model.
  • @instructlab-bot help -- Print this help message again.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below

Note

Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers instruct-lab-bot-maintainers]] teams are allowed to run these commands.

@jjasghar
Copy link
Member Author

jjasghar commented Jun 4, 2024

@instructlab-bot precheck

Copy link

Beep, boop 🤖, Generating test data for your PR with the job type: precheck. Your Job ID is 367. The results will be presented below in the pull request status box. This may take several minutes...

Copy link

Results for job ID: 367 using the model instructlab/granite-7b-lab!

Results can be found here.

@jjasghar
Copy link
Member Author

@instructlab-bot precheck

Copy link

Beep, boop 🤖, Generating test data for your PR with the job type: precheck. Your Job ID is 389. The results will be presented below in the pull request status box. This may take several minutes...

Copy link

Results for job ID: 389 using the model instructlab/granite-7b-lab!

Results can be found here.

@jjasghar jjasghar added community-build-ready Triage Team has signed off for synthetic data generation and removed precheck-generate-ready PR is ready for precheck or generate step labels Jun 10, 2024
Copy link

This pull request has been automatically marked as stale because it has not had activity within 15 days. It will be automatically closed if no further activity occurs within 31 days.

@github-actions github-actions bot added the stale stale-bot has marked you as stale label Jun 26, 2024
@jjasghar jjasghar removed the stale stale-bot has marked you as stale label Jun 27, 2024
@mcorbin-ibm
Copy link
Contributor

Per the new taxonomy (#1215 ), I recommend that this knowledge go here:

knowledge/science/astronomy/constellations/phoenix/

@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label Aug 21, 2024
@jjasghar jjasghar removed the triage-needed (Auto labeled) skill is ready to be triaged label Aug 21, 2024
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label Aug 21, 2024
@jjasghar jjasghar removed the triage-needed (Auto labeled) skill is ready to be triaged label Aug 21, 2024
This is the combined Phoenix Constellations PRs from Red Hat Summit
2024.

This superseeds #899 #940 #947 #950 #980 #999 #1009 #1025 #1042 #1056

Signed-off-by: JJ Asghar <awesome@ibm.com>
Co-authored-by: FourHole <fholifi1@gmail.com>
Co-authored-by: pcasal <pcasal@netlabs.com.uy>
Co-authored-by: gharunsaikumar <152345081+gharunsaikumar@users.noreply.github.com>
Co-authored-by: woodbb <64229105+woodbb@users.noreply.github.com>
Co-authored-by: Cosuazo <cosuazo@itpi.com.ph>
Co-authored-by: Robert Barron <robert.j.barron@gmail.com>
Co-authored-by: Narender Singh <54568962+narendermann@users.noreply.github.com>
Co-authored-by: eroglyph <eroglyph@users.noreply.github.com>
Co-authored-by: kevin77a <36176013+kevin77a@users.noreply.github.com>
Co-authored-by: redtempest25 <sivaram@redhat.com>
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label Aug 22, 2024
@jjasghar jjasghar added cmb-running We are running these in the CMB process and removed triage-needed (Auto labeled) skill is ready to be triaged labels Aug 22, 2024
@jjasghar
Copy link
Member Author

jjasghar commented Sep 3, 2024

Hi! 👋
Thank you for submitting this PR. We are ready to do some validation now, and we have a few candidates to see if they improve the model.
We some resources to run these release candidates, but we need you to help us. Can you reach out to me either on Slack (@awesome) or email me at awesomeATinstructlab.ai so I can get you access via ilab model chat?
We can only run these models for a "week" or so, so please reach out as soon as possible and tell me which one is best for you on this PR.

@jjasghar
Copy link
Member Author

jjasghar commented Sep 4, 2024

This one did not take very well.

It got " Is the Phoenix Constellation part of the Milky Way?" and "Are WASP-4 and WASP-5 solar-type yellow stars?" completely wrong.

/cc @juliadenham

@jjasghar jjasghar added triage-rejected PR fails to meet criteria and removed community-build-ready Triage Team has signed off for synthetic data generation cmb-running We are running these in the CMB process labels Sep 4, 2024
@jjasghar jjasghar closed this Sep 9, 2024
@jjasghar jjasghar added the follow-up-engineering This PR needs to be investigated by engineering label Sep 9, 2024
@ivanbaldo
Copy link

So this means that these will never be merged then?

@jjasghar
Copy link
Member Author

We are going to send this to the upstream engineering team to do some investigation on why it's didn't work. It's not "never," just not for the foreseeable future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow-up-engineering This PR needs to be investigated by engineering knowledge (Auto labeled) triage-rejected PR fails to meet criteria
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants