fix coding style issues and travis ci config

Author: dpfaffenbauer

.travis.yml

@@ -0,0 +1,17 @@
+language: php
+
+php:
+  - 5.3
+  - 5.4
+  - 5.5
+  - 5.6
+  - hhvm
+
+before_script:
+  - composer install -n --dev --prefer-source
+
+script: vendor/bin/phpcs --standard=PSR2 src && vendor/bin/phpunit --coverage-text --coverage-clover=coverage.clover
+
+after_script:
+    - wget https://scrutinizer-ci.com/ocular.phar
+    - php ocular.phar code-coverage:upload --format=php-clover coverage.clover

src/AbstractDatatransGateway.php

@@ -1,4 +1,16 @@
 <?php
+/**
+ * w-vision
+ *
+ * LICENSE
+ *
+ * This source file is subject to the GNU General Public License version 3 (GPLv3)
+ * For the full copyright and license information, please view the LICENSE.md and gpl-3.0.txt
+ * files that are distributed with this source code.
+ *
+ * @copyright  Copyright (c) 2016 Woche-Pass AG (http://www.w-vision.ch)
+ * @license    GNU General Public License version 3 (GPLv3)
+ */
 
 namespace Omnipay\Datatrans;
 
@@ -28,7 +40,8 @@ public function getDefaultParameters()
      * @param $value
      * @return $this
      */
-    public function setMerchantId($value) {
+    public function setMerchantId($value)
+    {
         return $this->setParameter('merchantId', $value);
     }
 
@@ -37,22 +50,25 @@ public function setMerchantId($value) {
      *
      * @return string
      */
-    public function getMerchantId() {
+    public function getMerchantId()
+    {
         return  $this->getParameter('merchantId');
     }
 
     /**
      * @param $value
      * @return $this
      */
-    public function setSign($value) {
+    public function setSign($value)
+    {
         return $this->setParameter('sign', $value);
     }
 
     /**
      * @return string
      */
-    public function getSign() {
+    public function getSign()
+    {
         return $this->getParameter('sign');
     }
 }

src/Gateway.php

@@ -1,13 +1,21 @@
 <?php
+/**
+ * w-vision
+ *
+ * LICENSE
+ *
+ * This source file is subject to the GNU General Public License version 3 (GPLv3)
+ * For the full copyright and license information, please view the LICENSE.md and gpl-3.0.txt
+ * files that are distributed with this source code.
+ *
+ * @copyright  Copyright (c) 2016 Woche-Pass AG (http://www.w-vision.ch)
+ * @license    GNU General Public License version 3 (GPLv3)
+ */
 
 namespace Omnipay\Datatrans;
 
-use Omnipay\Common\AbstractGateway;
-
 /**
  * Datatrans Gateway
- *
- * @TODO: add optional fields
  */
 class Gateway extends AbstractDatatransGateway
 {

src/Message/AbstractRequest.php

@@ -1,4 +1,16 @@
 <?php
+/**
+ * w-vision
+ *
+ * LICENSE
+ *
+ * This source file is subject to the GNU General Public License version 3 (GPLv3)
+ * For the full copyright and license information, please view the LICENSE.md and gpl-3.0.txt
+ * files that are distributed with this source code.
+ *
+ * @copyright  Copyright (c) 2016 Woche-Pass AG (http://www.w-vision.ch)
+ * @license    GNU General Public License version 3 (GPLv3)
+ */
 
 namespace Omnipay\Datatrans\Message;
 

src/Message/CompletePurchaseRequest.php

@@ -1,17 +1,32 @@
 <?php
+/**
+ * w-vision
+ *
+ * LICENSE
+ *
+ * This source file is subject to the GNU General Public License version 3 (GPLv3)
+ * For the full copyright and license information, please view the LICENSE.md and gpl-3.0.txt
+ * files that are distributed with this source code.
+ *
+ * @copyright  Copyright (c) 2016 Woche-Pass AG (http://www.w-vision.ch)
+ * @license    GNU General Public License version 3 (GPLv3)
+ */
 
 namespace Omnipay\Datatrans\Message;
 
-use Omnipay\Common\Exception\InvalidResponseException;
-
 class CompletePurchaseRequest extends AbstractRequest
 {
+    /**
+     * @return array
+     */
     public function getData()
     {
         return $this->httpRequest->request->all();
     }
 
-    // Sending the 1.x way
+    /**
+     * @return ResponseInterface
+     */
     public function send()
     {
         return $this->sendData($this->getData());

src/Message/CompletePurchaseResponse.php

@@ -1,4 +1,16 @@
 <?php
+/**
+ * w-vision
+ *
+ * LICENSE
+ *
+ * This source file is subject to the GNU General Public License version 3 (GPLv3)
+ * For the full copyright and license information, please view the LICENSE.md and gpl-3.0.txt
+ * files that are distributed with this source code.
+ *
+ * @copyright  Copyright (c) 2016 Woche-Pass AG (http://www.w-vision.ch)
+ * @license    GNU General Public License version 3 (GPLv3)
+ */
 
 namespace Omnipay\Datatrans\Message;
 
@@ -9,13 +21,19 @@
  */
 class CompletePurchaseResponse extends AbstractResponse
 {
+    /**
+     * @return bool
+     */
     public function isSuccessful()
     {
         $status = $this->getStatus();
 
         return $status === 'success';
     }
 
+    /**
+     * @return string
+     */
     public function getMessage()
     {
         if (!$this->isSuccessful()) {
@@ -25,13 +43,19 @@ public function getMessage()
         return '';
     }
 
-
+    /**
+     * @return string
+     */
     public function getTransactionReference()
     {
         return isset($this->data['refno']) ? $this->data['refno'] : '';
     }
 
-    public function getStatus() {
+    /**
+     * @return mixed
+     */
+    public function getStatus()
+    {
         return $this->data['status'];
     }
 }

src/Message/PurchaseRequest.php

@@ -1,15 +1,33 @@
 <?php
+/**
+ * w-vision
+ *
+ * LICENSE
+ *
+ * This source file is subject to the GNU General Public License version 3 (GPLv3)
+ * For the full copyright and license information, please view the LICENSE.md and gpl-3.0.txt
+ * files that are distributed with this source code.
+ *
+ * @copyright  Copyright (c) 2016 Woche-Pass AG (http://www.w-vision.ch)
+ * @license    GNU General Public License version 3 (GPLv3)
+ */
 
 namespace Omnipay\Datatrans\Message;
 
-use Omnipay\Common\CreditCard;
+use Omnipay\Common\Message\ResponseInterface;
 
 class PurchaseRequest extends AbstractRequest
 {
+    /**
+     * @var array
+     */
     protected $optionalParams = array(
 
     );
 
+    /**
+     * @return array
+     */
     public function getData()
     {
         $this->validate('merchantId', 'transactionId', 'sign');
@@ -40,20 +58,24 @@ public function getData()
 
     /**
      * @param $value
-     * @return $this
+     * @return string
      */
-    public function setErrorUrl($value) {
+    public function setErrorUrl($value)
+    {
         return $this->setParameter('errorUrl', $value);
     }
 
     /**
      * @return string
      */
-    public function getErrorUrl() {
+    public function getErrorUrl()
+    {
         return $this->getParameter('errorUrl');
     }
 
-    // Send request the 1.x way
+    /**
+     * @return ResponseInterface
+     */
     public function send()
     {
         return $this->sendData($this->getData());

src/Message/PurchaseResponse.php

@@ -1,4 +1,16 @@
 <?php
+/**
+ * w-vision
+ *
+ * LICENSE
+ *
+ * This source file is subject to the GNU General Public License version 3 (GPLv3)
+ * For the full copyright and license information, please view the LICENSE.md and gpl-3.0.txt
+ * files that are distributed with this source code.
+ *
+ * @copyright  Copyright (c) 2016 Woche-Pass AG (http://www.w-vision.ch)
+ * @license    GNU General Public License version 3 (GPLv3)
+ */
 
 namespace Omnipay\Datatrans\Message;
 
@@ -74,7 +86,7 @@ protected function getCheckoutEndpoint()
     {
         $req = $this->getRequest();
 
-        if($req->getTestMode()) {
+        if ($req->getTestMode()) {
             return $this->testEndpoint;
         }