Skip to content

Commit d19f304

Browse files
authored
chore(minio): always print audit logs (#151)
Because - We want to always print the MinIO audit logs. If we make this behaviour configurable, it'll be after it's released and verified. This commit - Remove config variable to toggle MinIO webhook behaviour.
1 parent da0b848 commit d19f304

File tree

4 files changed

+3
-10
lines changed

4 files changed

+3
-10
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM --platform=$TARGETPLATFORM golang:1.23.4 AS build
1+
FROM golang:1.23.4 AS build
22

33
WORKDIR /src
44

cmd/main/main.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -258,11 +258,8 @@ func main() {
258258
logger.Fatal(err.Error())
259259
}
260260

261-
if config.Config.Server.IngestMinIOLogs {
262-
err := privateServeMux.HandlePath("POST", "/v1alpha/minio-audit", privateHandler.IngestMinIOAuditLogs)
263-
if err != nil {
264-
logger.Fatal("Failed to set up MinIO audit endpoint", zap.Error(err))
265-
}
261+
if err := privateServeMux.HandlePath("POST", "/v1alpha/minio-audit", privateHandler.IngestMinIOAuditLogs); err != nil {
262+
logger.Fatal("Failed to set up MinIO audit endpoint", zap.Error(err))
266263
}
267264

268265
privateHTTPServer := &http.Server{

config/config.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,6 @@ type ServerConfig struct {
6969
MaxWorkflowRetry int32 `koanf:"maxworkflowretry"`
7070
MaxActivityRetry int32 `koanf:"maxactivityretry"`
7171
}
72-
73-
// IngestMinIOLogs enables the MinIO audit log webhook.
74-
IngestMinIOLogs bool `koanf:"logminioaudit"`
7572
}
7673

7774
// DatabaseConfig related to database

config/config.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ server:
1616
maxworkflowtimeout: 3600 # in seconds
1717
maxworkflowretry: 1
1818
maxactivityretry: 3
19-
logminioaudit: true
2019
database:
2120
username: postgres
2221
password: password

0 commit comments

Comments
 (0)