Make bash kernel ID file path determination more robust

- Replace brittle string replacement with robust path construction using os.path.dirname()
- Add bash_kernel_id_file property to Config class for centralized path management
- Update tests to use new robust approach
- Add test coverage for custom kernel file path scenarios
- Ensures compatibility with any custom CODERUNNER_KERNEL_ID_FILE configuration

Author: abhishek-anand

config.py

@@ -44,6 +44,11 @@ def __init__(self, **kwargs):
         if self.kernel_id_file is None:
             self.kernel_id_file = str(self.shared_dir / "python_kernel_id.txt")
 
+    @property
+    def bash_kernel_id_file(self) -> str:
+        """Get the path for the bash kernel ID file"""
+        return os.path.join(os.path.dirname(self.kernel_id_file), "bash_kernel_id.txt")
+    
     @property
     def jupyter_ws_base_url(self) -> str:
         """Get the base WebSocket URL for Jupyter"""

jupyter_client.py

@@ -38,7 +38,7 @@ def _load_kernel_ids(self) -> None:
         """Load kernel IDs from files"""
         kernel_files = {
             "python": config.kernel_id_file,
-            "bash": config.kernel_id_file.replace("python_kernel_id.txt", "bash_kernel_id.txt")
+            "bash": config.bash_kernel_id_file
         }
 
         for kernel_type, kernel_file in kernel_files.items():

tests/test_config.py

@@ -73,5 +73,20 @@ def test_config_kernel_id_file_path():
         shared_dir = pathlib.Path(tmp_dir) / "uploads"
         config = Config(shared_dir=shared_dir)
 
-        expected_path = str(shared_dir / "python_kernel_id.txt")
-        assert config.kernel_id_file == expected_path
+        expected_python_path = str(shared_dir / "python_kernel_id.txt")
+        expected_bash_path = str(shared_dir / "bash_kernel_id.txt")
+        
+        assert config.kernel_id_file == expected_python_path
+        assert config.bash_kernel_id_file == expected_bash_path
+
+
+def test_config_bash_kernel_id_file_with_custom_path():
+    """Test that bash kernel ID file path is robust to custom python kernel path"""
+    with tempfile.TemporaryDirectory() as tmp_dir:
+        custom_python_path = os.path.join(tmp_dir, "custom", "my_python_kernel.txt")
+        os.makedirs(os.path.dirname(custom_python_path), exist_ok=True)
+        
+        config = Config(kernel_id_file=custom_python_path)
+        
+        expected_bash_path = os.path.join(tmp_dir, "custom", "bash_kernel_id.txt")
+        assert config.bash_kernel_id_file == expected_bash_path

tests/test_jupyter_client.py

@@ -77,7 +77,7 @@ def test_init_with_bash_kernel(self, mock_config):
         with open(mock_config.kernel_id_file, 'w') as f:
             f.write(python_kernel_id)
 
-        bash_kernel_file = mock_config.kernel_id_file.replace("python_kernel_id.txt", "bash_kernel_id.txt")
+        bash_kernel_file = mock_config.bash_kernel_id_file
         with open(bash_kernel_file, 'w') as f:
             f.write(bash_kernel_id)
 
@@ -238,7 +238,7 @@ async def test_execute_code_connection_error(self, jupyter_client_with_kernel):
     async def test_execute_bash_code_success(self, mock_config):
         """Test successful bash code execution"""
         # Create bash kernel file
-        bash_kernel_file = mock_config.kernel_id_file.replace("python_kernel_id.txt", "bash_kernel_id.txt")
+        bash_kernel_file = mock_config.bash_kernel_id_file
         with open(bash_kernel_file, 'w') as f:
             f.write("bash-kernel-789")
 
@@ -311,7 +311,7 @@ def test_reload_kernel_ids(self, mock_config):
         with open(mock_config.kernel_id_file, 'w') as f:
             f.write("new-python-kernel-456")
 
-        bash_kernel_file = mock_config.kernel_id_file.replace("python_kernel_id.txt", "bash_kernel_id.txt")
+        bash_kernel_file = mock_config.bash_kernel_id_file
         with open(bash_kernel_file, 'w') as f:
             f.write("new-bash-kernel-789")