Otel change span structure #448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cagri Yonca <cagri@ibm.com>
Base automatically changed from
move-tracer-to-otel-standards
to
otel-migration
March 24, 2025 08:55
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
arjun-rajappa
force-pushed
the
otel-change-span-structure
branch
from
012142b to
b460adc
Compare
Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
pvital
requested changes
May 12, 2025
Comment on lines
+17
to
+18
| trace_id: Trace.generate_trace_id, | ||
| span_id: Trace.generate_span_id, |
There was a problem hiding this comment.
When creating a new Span and then a new SpanContext, the trace_id and span_id must be the same if not being created from a parent Span. Is this generate_span_id method considering this?
One more thing. It would be nice to update the comment block with the new arguments before this method.
Comment on lines
+16
to
+22
|
|
||
| def test_donot_commit | ||
| # span = Instana.tracer_provider.tracer("instana_tracer").in_span("sdk") do | ||
| # print("abc") | ||
| # end | ||
| # Instana.processor | ||
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.