[INSTA-47091] fix: Improved getting active tracer and current span mechanism #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSVarsha
requested changes
Nov 13, 2025
Contributor
GSVarsha
left a comment
GSVarsha
left a comment
There was a problem hiding this comment.
We shouldn't return if the tracer is inactive for server spans like wsgi, sanic, etc because those would (mostly) be the first spans (entry) starting the trace.
CagriYonca
force-pushed
the
active-tracer
branch
from
15c0259 to
64c5a08
Compare
CagriYonca
force-pushed
the
active-tracer
branch
from
64c5a08 to
f033b71
Compare
|
CagriYonca
changed the title
CagriYonca
force-pushed
the
active-tracer
branch
2 times, most recently
from
6ebabac to
e5e52b7
Compare
Signed-off-by: Cagri Yonca <cagri@ibm.com>
CagriYonca
force-pushed
the
active-tracer
branch
from
e5e52b7 to
1702ae2
Compare
Signed-off-by: Cagri Yonca <cagri@ibm.com>
CagriYonca
force-pushed
the
active-tracer
branch
from
1702ae2 to
8c87bd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracing_is_offfunction is also widely used in almost every instrumentation and it only returns whether the tracer is ready to record a new span or not. As I already explained above, we already have this information in the tracer, so that by combining these two functions into get_tracer_tuple function, we're getting rid of 1 get_current_span call and functionality oftracing_is_offfunction since we can directly check if the tracer in the instrumentation is False or not.get_active_tracerandtracing_is_offfunctions has been removed