unit test added and updated

Author: jobykorahgeorgeibm

Sources/InstanaAgent/Beacons/Beacons Types/ViewChange.swift

@@ -8,6 +8,8 @@ class ViewChange: Beacon {
     var accessibilityLabel: String?
     var navigationItemTitle: String?
     var className: String?
+    
+    // Internal Meta only to be consumed by Flutter/React agents
     var viewInternalCPMetaMap: [String: String]
 
     init(timestamp: Instana.Types.Milliseconds = Date().millisecondsSince1970,

Sources/InstanaAgent/Beacons/CoreBeacon/CoreBeaconFactory.swift

@@ -109,6 +109,7 @@ extension CoreBeacon {
         if beacon.className != nil {
             im![internalMetaDataKeyView_className] = beacon.className!
         }
+        // Only when there is view meta available from crossplatfrom agents(Flutter/React-Native) thats added with every view change
         if !beacon.viewInternalCPMetaMap.isEmpty {
             for (key, value) in beacon.viewInternalCPMetaMap {
                 im![key] = value

Tests/InstanaAgentTests/Beacons/Beacon Types/ViewChangeBeaconTests.swift

@@ -117,14 +117,14 @@ class ViewChangeBeaconTests: InstanaTestCase {
 
     func test_init_viewInternalMetaMap() {
         let vcBeacon = ViewChange(timestamp: testTimestamp, viewName: testViewName,
-                                  accessibilityLabel: nil, navigationItemTitle: nil, className: nil,viewInternalMetaMap: testViewInternalMetaMap)
-        XCTAssertEqual(vcBeacon.viewInternalMetaMap,testViewInternalMetaMap)
+                                  accessibilityLabel: nil, navigationItemTitle: nil, className: nil,viewInternalCPMetaMap: testViewInternalMetaMap)
+        XCTAssertEqual(vcBeacon.viewInternalCPMetaMap,testViewInternalMetaMap)
     }
 
     func test_init_viewInternalMetaMap_empty() {
         let vcBeacon = ViewChange(timestamp: testTimestamp, viewName: testViewName,
                                   accessibilityLabel: nil, navigationItemTitle: nil, className: nil)
-        XCTAssertEqual(vcBeacon.viewInternalMetaMap,[:])
+        XCTAssertEqual(vcBeacon.viewInternalCPMetaMap,[:])
     }
 
 

Tests/InstanaAgentTests/InstanaTests.swift

@@ -828,23 +828,51 @@ class InstanaTests: InstanaTestCase {
         AssertFalse(Instana.collectionEnabled)
     }
 
-    func test_setViewMetaCPInternal_called(){
+    func test_setViewMetaCPInternal_called_negative(){
         // Given
         let session = InstanaSession.mock(configuration: .mock())
 
         var viewChangeBeaconCount = 0
         var capturedViewInternalMetaMap: [String: String]? = nil
         let reporter = MockReporter {
             if let viewChange = $0 as? ViewChange {
-                capturedViewInternalMetaMap = viewChange.viewInternalMetaMap
+                capturedViewInternalMetaMap = viewChange.viewInternalCPMetaMap
                 viewChangeBeaconCount += 1
             }
         }
         Instana.current = Instana(session: session, monitors: Monitors(session, reporter: reporter))
 
         let testViewInternalMetaMap = ["key1": "value1", "key2": "value2"]
         // When
-        Instana.setViewMetaCPInternal(name: "ScreenName", viewInternalMetaMap:testViewInternalMetaMap)
+        Instana.setViewMetaCPInternal(name: "ScreenName", viewInternalCPMetaMap:testViewInternalMetaMap)
+        
+        Instana.current?.setViewInternal(name: nil) // nil view name should not trigger ViewChange beacon
+        Thread.sleep(forTimeInterval: 1)
+
+        // Then
+        AssertEqualAndNotNil(viewChangeBeaconCount, 0)
+        AssertEqualAndNotNil(capturedViewInternalMetaMap, nil)
+    }
+    
+    func test_setViewMetaCPInternal_called_positive(){
+        // Given
+        let session = InstanaSession.mock(configuration: .mock())
+
+        var viewChangeBeaconCount = 0
+        var capturedViewInternalMetaMap: [String: String]? = nil
+        let reporter = MockReporter {
+            if let viewChange = $0 as? ViewChange {
+                capturedViewInternalMetaMap = viewChange.viewInternalCPMetaMap
+                viewChangeBeaconCount += 1
+            }
+        }
+        Instana.current = Instana(session: session, monitors: Monitors(session, reporter: reporter))
+
+        let testViewInternalMetaMap = ["settings.route.name": "value1", "widget.name": "value2"]
+        
+        
+        // When
+        Instana.setViewMetaCPInternal(name: "ScreenName", viewInternalCPMetaMap:testViewInternalMetaMap)
 
         Instana.current?.setViewInternal(name: nil) // nil view name should not trigger ViewChange beacon
         Thread.sleep(forTimeInterval: 1)