Skip to content

Commit 952bc2b

Browse files
committed
Don't forward urlSession(_ session: dataTask: didReceive:completionHandler)
Responses might get lost
1 parent 498991d commit 952bc2b

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

Sources/InstanaAgent/Monitors/HTTP/InstanaURLProtocol.swift

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -212,16 +212,13 @@ extension InstanaURLProtocol: URLSessionTaskDelegate {
212212
}
213213

214214
extension InstanaURLProtocol: URLSessionDataDelegate {
215-
func urlSession(_ session: URLSession, dataTask: URLSessionDataTask, didReceive response: URLResponse, completionHandler: @escaping (URLSession.ResponseDisposition) -> Void) {
216-
if let originalSession = originalTask?.internalSession, let delegate = originalSession.delegate as? URLSessionDataDelegate,
217-
delegate.responds(to: #selector(urlSession(_:dataTask:didReceive:completionHandler:))) {
218-
dispatch(on: originalSession.delegateQueue.underlyingQueue) {
219-
delegate.urlSession?(originalSession, dataTask: dataTask, didReceive: response, completionHandler: completionHandler)
220-
}
221-
} else {
222-
client?.urlProtocol(self, didReceive: response, cacheStoragePolicy: .allowed)
223-
completionHandler(.allow)
224-
}
215+
216+
func urlSession(_ session: URLSession,
217+
dataTask: URLSessionDataTask,
218+
didReceive response: URLResponse,
219+
completionHandler: @escaping (URLSession.ResponseDisposition) -> Void) {
220+
client?.urlProtocol(self, didReceive: response, cacheStoragePolicy: .allowed)
221+
completionHandler(.allow)
225222
}
226223

227224
func urlSession(_ session: URLSession, dataTask: URLSessionDataTask, didBecome downloadTask: URLSessionDownloadTask) {

0 commit comments

Comments
 (0)