added ut for max count, added max count logic

Author: jobykorahgeorgeibm

Sources/InstanaAgent/Beacons/Beacons Types/ViewChange.swift

@@ -8,7 +8,7 @@ class ViewChange: Beacon {
     var accessibilityLabel: String?
     var navigationItemTitle: String?
     var className: String?
-    
+
     // Internal Meta only to be consumed by Flutter/React agents
     var viewInternalCPMetaMap: [String: String]
 
@@ -37,7 +37,7 @@ class ViewChange: Beacon {
             }
         }
         for (key, value) in viewInternalCPMetaMap {
-            self.viewInternalCPMetaMap[key] = value
+            self.viewInternalCPMetaMap[key] = ViewChange.validate(viewName: value)
         }
         super.init(timestamp: timestamp, viewName: canonicalName)
     }

Sources/InstanaAgent/Beacons/CoreBeacon/CoreBeaconFactory.swift

@@ -109,7 +109,6 @@ extension CoreBeacon {
         if beacon.className != nil {
             im![internalMetaDataKeyView_className] = beacon.className!
         }
-        // Only when there is view meta available from crossplatfrom agents(Flutter/React-Native) thats added with every view change
         if !beacon.viewInternalCPMetaMap.isEmpty {
             for (key, value) in beacon.viewInternalCPMetaMap {
                 im![key] = value

Tests/InstanaAgentTests/InstanaTests.swift

@@ -881,4 +881,37 @@ class InstanaTests: InstanaTestCase {
         AssertEqualAndNotNil(viewChangeBeaconCount, 1)
         AssertEqualAndNotNil(capturedViewInternalMetaMap, testViewInternalMetaMap)
     }
+    
+    func test_setViewMetaCPInternal_called_with_max_value_length(){
+        // Given
+        let session = InstanaSession.mock(configuration: .mock())
+
+        var viewChangeBeaconCount = 0
+        var capturedViewInternalMetaMap: [String: String]? = nil
+        let reporter = MockReporter {
+            if let viewChange = $0 as? ViewChange {
+                capturedViewInternalMetaMap = viewChange.viewInternalCPMetaMap
+                viewChangeBeaconCount += 1
+            }
+        }
+        Instana.current = Instana(session: session, monitors: Monitors(session, reporter: reporter))
+        var randomString = ""
+        for _ in 0..<InstanaProperties.viewMaxLength+3 {
+            let randomCharacter = Character(UnicodeScalar(UInt32.random(in: 65...90)) ?? "A") // A-Z
+            randomString.append(randomCharacter)
+        }
+
+        let testViewInternalMetaMap = ["settings.route.name": randomString, "widget.name": "value2"]
+        
+        
+        // When
+        Instana.setViewMetaCPInternal(name: "ScreenName", viewInternalCPMetaMap:testViewInternalMetaMap)
+        
+        Instana.current?.setViewInternal(name: nil) // nil view name should not trigger ViewChange beacon
+        Thread.sleep(forTimeInterval: 1)
+
+        // Then
+        AssertEqualAndNotNil(viewChangeBeaconCount, 1)
+        AssertEqualAndNotNil(capturedViewInternalMetaMap?["settings.route.name"]?.count, InstanaProperties.viewMaxLength)
+    }
 }