Fix memory leak (#64)

* fix memory leak on behalf of NWPathMonitor instanace

* fix BeaconFlusher memory leak

* restore disapatchGroup.notify closure handling

* bump version to 1.8.6

Author: Hongyan Jiang

Changelog.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 1.8.6
+- fix memory leak
+
 ## 1.8.5
 - detect Application Not Responding scenario
 - remove code for iOS versions lower than 12

InstanaAgent.podspec

@@ -16,7 +16,7 @@ Pod::Spec.new do |s|
   #
 
   s.name         = "InstanaAgent"
-  s.version      = "1.8.5"
+  s.version      = "1.8.6"
   s.summary      = "Instana iOS agent."
 
   # This description is used to generate tags and improve search results.

Sources/InstanaAgent/Beacons/BeaconFlusher.swift

@@ -107,13 +107,12 @@ class BeaconFlusher {
                 disapatchGroup.leave()
                 return
             }
-            send(request) { [weak self] sentResult in
-                guard let self = self else { return }
+            send(request) { [weak self, capturedBeacons = beaconBatch] sentResult in
                 switch sentResult {
                 case .success:
-                    self.sentBeacons.formUnion(beaconBatch)
+                    self?.sentBeacons.formUnion(capturedBeacons)
                 case let .failure(error):
-                    self.errors.append(error)
+                    self?.errors.append(error)
                 }
                 disapatchGroup.leave()
             }

Sources/InstanaAgent/Beacons/HJFakeFlusher.swift

@@ -1,3 +1,3 @@
 struct VersionConfig {
-    static let agentVersion = "1.8.5"
+    static let agentVersion = "1.8.6"
 }

Sources/InstanaAgent/Configuration/VersionConfig.swift

@@ -7,6 +7,7 @@ import Foundation
 import Network
 
 class NetworkUtility {
+    let nwPathMonitor = NWPathMonitor()
     var connectionType: ConnectionType = .undetermined {
         didSet {
             if oldValue != .undetermined {
@@ -20,7 +21,6 @@ class NetworkUtility {
 
     init(observeNetworkChanges: Bool = true) {
         if #available(iOS 12.0, *) {
-            let nwPathMonitor = NWPathMonitor()
             nwPathMonitor.pathUpdateHandler = { path in
                 if path.usesInterfaceType(.wifi) {
                     self.update(.wifi)

Sources/InstanaAgent/Utils/Networking/NetworkUtility.swift

@@ -5,7 +5,7 @@ class InstanaSystemUtilsTests: InstanaTestCase {
 
     func test_AgentVersion() {
         // Then
-        AssertTrue(InstanaSystemUtils.agentVersion == "1.8.5")
+        AssertTrue(InstanaSystemUtils.agentVersion == "1.8.6")
     }
 
     func test_systemVersion() {