Skip to content

Commit 340e6e4

Browse files
Hongyan JiangGitHub Enterprise
authored andcommitted
Prepare release 1.6.0 (#9)
* Refactor code * Add more Unit Tests * Add requirements to README.md * Update Changelog.md
1 parent ac4e190 commit 340e6e4

File tree

69 files changed

+3609
-87
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+3609
-87
lines changed

Changelog.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Changelog
22

3+
## 1.6.0
4+
- Refactor code and add more unit test cases
5+
36
## 1.5.2
47
- Add new atomic types for some collections to improve thread safety
58

Dev/InstanaAgentExample.xcodeproj/project.pbxproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -629,7 +629,7 @@
629629
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
630630
GCC_WARN_UNUSED_FUNCTION = YES;
631631
GCC_WARN_UNUSED_VARIABLE = YES;
632-
IPHONEOS_DEPLOYMENT_TARGET = 14.4;
632+
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
633633
MTL_ENABLE_DEBUG_INFO = NO;
634634
MTL_FAST_MATH = YES;
635635
SDKROOT = iphoneos;

Dev/InstanaAgentExample.xcodeproj/xcshareddata/xcschemes/iOSAgentExample.xcscheme

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,18 @@
2626
buildConfiguration = "Debug"
2727
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
2828
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
29-
shouldUseLaunchSchemeArgsEnv = "YES">
29+
shouldUseLaunchSchemeArgsEnv = "YES"
30+
codeCoverageEnabled = "YES"
31+
onlyGenerateCoverageForSpecifiedTargets = "YES">
32+
<CodeCoverageTargets>
33+
<BuildableReference
34+
BuildableIdentifier = "primary"
35+
BlueprintIdentifier = "InstanaAgentTests"
36+
BuildableName = "InstanaAgentTests"
37+
BlueprintName = "InstanaAgentTests"
38+
ReferencedContainer = "container:..">
39+
</BuildableReference>
40+
</CodeCoverageTargets>
3041
<Testables>
3142
<TestableReference
3243
skipped = "NO">
@@ -38,6 +49,16 @@
3849
ReferencedContainer = "container:InstanaAgentExample.xcodeproj">
3950
</BuildableReference>
4051
</TestableReference>
52+
<TestableReference
53+
skipped = "NO">
54+
<BuildableReference
55+
BuildableIdentifier = "primary"
56+
BlueprintIdentifier = "InstanaAgentTests"
57+
BuildableName = "InstanaAgentTests"
58+
BlueprintName = "InstanaAgentTests"
59+
ReferencedContainer = "container:..">
60+
</BuildableReference>
61+
</TestableReference>
4162
</Testables>
4263
</TestAction>
4364
<LaunchAction

Dev/InstanaAgentExample/AppDelegate.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,22 @@ import InstanaAgent
99

1010
@UIApplicationMain
1111
class AppDelegate: UIResponder, UIApplicationDelegate {
12+
var window: UIWindow? // needed on iOS 12 or lower
1213

1314
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
1415
Instana.setup(key: InstanaKey, reportingURL: InstanaURL)
1516
return true
1617
}
1718

1819
// MARK: UISceneSession Lifecycle
19-
20+
@available(iOS 13.0, *)
2021
func application(_ application: UIApplication, configurationForConnecting connectingSceneSession: UISceneSession, options: UIScene.ConnectionOptions) -> UISceneConfiguration {
2122
// Called when a new scene session is being created.
2223
// Use this method to select a configuration to create the new scene with.
2324
return UISceneConfiguration(name: "Default Configuration", sessionRole: connectingSceneSession.role)
2425
}
2526

27+
@available(iOS 13.0, *)
2628
func application(_ application: UIApplication, didDiscardSceneSessions sceneSessions: Set<UISceneSession>) {
2729
// Called when the user discards a scene session.
2830
// If any sessions were discarded while the application was not running, this will be called shortly after application:didFinishLaunchingWithOptions.

Dev/InstanaAgentExample/EventListViewController.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ struct DataSource: Codable {
1616
let results: [Event]
1717
}
1818

19+
@available(iOS 13.0, *)
1920
class EventListViewController: UITableViewController {
2021

2122
private var publisher: AnyCancellable?
@@ -71,6 +72,7 @@ class EventListViewController: UITableViewController {
7172
}
7273
}
7374

75+
@available(iOS 13.0, *)
7476
class DetailViewController: UIViewController {
7577

7678
let label = UILabel()

Dev/InstanaAgentExample/ImageViewController.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import InstanaAgent
1010
import AFNetworking
1111
import Alamofire
1212

13+
@available(iOS 13.0, *)
1314
class ImageViewViewController: UIViewController {
1415

1516
lazy var imageView = UIImageView()

Dev/InstanaAgentExample/JSONViewController.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import UIKit
88
import Combine
99
import InstanaAgent
1010

11+
@available(iOS 13.0, *)
1112
class JSONViewController: UIViewController {
1213

1314
@IBOutlet var searchTextField: UITextField!
@@ -45,13 +46,15 @@ class JSONViewController: UIViewController {
4546
}
4647
}
4748

49+
@available(iOS 13.0, *)
4850
extension JSONViewController: UITextFieldDelegate {
4951
func textFieldShouldReturn(_ textField: UITextField) -> Bool {
5052
loadJSON()
5153
return true
5254
}
5355
}
5456

57+
@available(iOS 13.0, *)
5558
extension Subscribers.Completion {
5659
var error: Error? {
5760
switch self {

Dev/InstanaAgentExample/README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# InstanaAgentExample
2+
3+
This is a test app for iosAgent framework testing.
4+
5+
- iOS version 13.0 or above is fully supported.
6+
- There is very limited support for iOS versions below 13.0. The main purpose is to test crash catching, make sure it's disabled.
7+
- If run on device, replace test bundle id com.instana.ios.InstanaAgentExample with a real one otherwise certain features like crash catching will not work.

Dev/InstanaAgentExample/SceneDelegate.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,10 @@
77

88
import UIKit
99

10+
@available(iOS 13.0, *)
1011
class SceneDelegate: UIResponder, UIWindowSceneDelegate {
11-
1212
var window: UIWindow?
1313

14-
1514
func scene(_ scene: UIScene, willConnectTo session: UISceneSession, options connectionOptions: UIScene.ConnectionOptions) {
1615
// Use this method to optionally configure and attach the UIWindow `window` to the provided UIWindowScene `scene`.
1716
// If using a storyboard, the `window` property will automatically be initialized and attached to the scene.

Dev/InstanaAgentExample/ViewController.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// iOSAgentExample
44
// Copyright © 2021 IBM Corp. All rights reserved.
55
//
6-
76
import UIKit
87

98
class ViewController: UITabBarController {

0 commit comments

Comments
 (0)