Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataset test display #123

Closed
wants to merge 1 commit into from

Conversation

katie-murphy-ck
Copy link

Per the README, this is a small enough change not to require the usual procedure. When running a test on a dataset, an internal Ruby reference to the resource is displayed instead of the dataset name. I stole this syntax from code in other library files.

Per the README, this is a small enough change not to require the usual procedure. When running a test on a dataset, an internal Ruby reference to the resource is displayed instead of the dataset name. I stole this syntax from code in other library files.
@katie-murphy-ck
Copy link
Author

This is related to issue #125

@slevenick
Copy link
Collaborator

This change will not fix the issue described in #125

The issue is that the nested object at libraries/google/bigquery/dataset_access.rb needs a similar to_s method, as that is the object that to_s is called on.

I would prefer to programmatically implement the to_s method on MM generated resources & nested objects. I'll look into possible solutions and keep the issue updated.

skpaterson pushed a commit that referenced this pull request Mar 20, 2019
@skpaterson
Copy link

Thanks for contributing @katie-murphy-ck, hopefully #127 from @slevenick resolves this issue but please let us know if there are any problems!

@skpaterson skpaterson closed this Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants