Node Pool fails requiring cluster_id

[darkn3rd]

Summary

Cannot test node_pool, undocumented and untested requirement for cluster_id.

Reproduce

  describe google_container_node_pool(project: PROJECT_NAME, zone: CLUSTER_ZONE, name: CLUSTER_NAME) do
    it { should exist }
    its('name') { should eq 'default-pool' }
    its('status') { should eq 'in_use' }
    its('config.disk_size_gb') { should eq 100 }
    its('config.machine_type') { should eq 'n1-standard-1' }
  end

OR

  describe google_container_node_pool(project: PROJECT_NAME, zone: CLUSTER_ZONE, name: CLUSTER_NAME, nodepool_name: 'default-pool') do
    it { should exist }
    its('name') { should eq 'default-pool' }
    its('status') { should eq 'in_use' }
    its('config.disk_size_gb') { should eq 100 }
    its('config.machine_type') { should eq 'n1-standard-1' }
  end

Actual

     ×  Nodepool guestbook
     'cluster_id' or cluster in 'parent' must be specified.

Expected

Test should work with cluster name. I don't know about some cluster id, it is not in the source code or integration tests.

Using this for Documentation:

• https://github.com/inspec/inspec-gcp/blob/master/libraries/google_container_node_pool.rb#L11-L18
• https://github.com/inspec/inspec-gcp/blob/master/test/integration/verify/controls/container_nodepool.rb#L13

Notes

gcloud container node-pools list --cluster guestbook
NAME          MACHINE_TYPE   DISK_SIZE_GB  NODE_VERSION
default-pool  n1-standard-1  100           1.8.10-gke.0

[skpaterson]

As correctly pointed out in #19, the documentation was incorrect here, the second example should work as expected but with cluster_name instead of name e.g.

  describe google_container_node_pool(project: PROJECT_NAME, zone: CLUSTER_ZONE, cluster_name: CLUSTER_NAME, nodepool_name: 'default-pool') do
    it { should exist }
    its('name') { should eq 'default-pool' }
    its('status') { should eq 'in_use' }
    its('config.disk_size_gb') { should eq 100 }
    its('config.machine_type') { should eq 'n1-standard-1' }

Rest assured the documentation will be updated to better reflect the arguments.