New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use `process.exit()` in the bin script #23

Closed

insin opened this issue Dec 16, 2015 · 0 comments

Owner

insin commented Dec 16, 2015

Using process.exit() instead of throwing or calling back where appropriate makes it fiddly to test, and to test with coverage.

It's currently being used in:

src/cli.js
src/commands/build-umd.js
src/commands/new.js
src/commands/serve-react.js
src/commands/serve.js
src/createServeReactAppBuildConfig.js
src/createWebpackConfig.js
src/devServer.js
src/getUserConfig.js
src/webpackBuild.js

The text was updated successfully, but these errors were encountered:

insin modified the milestone: 0.6

insin added a commit that referenced this issue


          Use the bin script to handle reporting of dev server startup errors

415a3c9

#23

insin closed this as completed in

e1d177d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment