tests: only use public functions

Author: averissimo

tests/testthat/helper-functions.R

@@ -0,0 +1,9 @@
+local_logger_threshold <- function(threshold, envir = parent.frame()) {
+  old <- logger::log_threshold(namespace = "teal.modules.general")
+  if (!requireNamespace("withr", quietly = FALSE)) {
+    return(invisible(old))
+  }
+  withr::defer(logger::log_threshold(old, namespace = "teal.modules.general"), envir = envir)
+  logger::log_threshold(threshold, namespace = "teal.modules.general")
+  invisible(old)
+}

tests/testthat/test-utils.R

@@ -1,14 +1,44 @@
 testthat::test_that("assert_single_selection succeeds if all elements have multiple choices disabled", {
+  # Suppress logger messages
+  local_logger_threshold(logger::FATAL)
+
   mock_spec <- data_extract_spec(
     dataname = "MOCK_DATASET",
     select = teal.transform::select_spec(choices = c("A", "B"), multiple = FALSE)
   )
 
-  testthat::expect_true(assert_single_selection(list(mock_spec)))
-  testthat::expect_true(assert_single_selection(list(mock_spec, mock_spec)))
+  testthat::expect_s3_class(
+    tm_g_bivariate(
+      "a label",
+      mock_spec,
+      mock_spec
+    ),
+    "teal_module"
+  )
+
+  testthat::expect_s3_class(
+    tm_g_bivariate(
+      "a label",
+      list(mock_spec),
+      mock_spec
+    ),
+    "teal_module"
+  )
+
+  testthat::expect_s3_class(
+    tm_g_bivariate(
+      "a label",
+      list(mock_spec, mock_spec),
+      mock_spec
+    ),
+    "teal_module"
+  )
 })
 
 testthat::test_that("assert_single_selection fails when multiple selection is selected in any of the specs", {
+  # Suppress logger messages
+  local_logger_threshold(logger::FATAL)
+
   mock_spec <- data_extract_spec(
     dataname = "MOCK_DATASET",
     select = teal.transform::select_spec(choices = c("A", "B"), multiple = TRUE)
@@ -21,56 +51,20 @@ testthat::test_that("assert_single_selection fails when multiple selection is se
   x <- list(mock_spec)
 
   testthat::expect_error(
-    assert_single_selection(x),
-    "'x' should not allow multiple selection"
-  )
-  testthat::expect_error(
-    assert_single_selection(list(mock_spec2, mock_spec), .var.name = "x"),
-    "'x' should not allow multiple selection"
-  )
-})
-
-testthat::test_that("assert_single_selection fails when multiple selection is enabled", {
-  mock_spec <- data_extract_spec(
-    dataname = "MOCK_DATASET",
-    select = teal.transform::select_spec(choices = c("A", "B"), multiple = TRUE)
-  )
-
-  # Suppress logger messages
-  logger::with_log_threshold(
-    testthat::expect_error(
-      tm_g_bivariate(
-        "a label",
-        mock_spec,
-        mock_spec
-      ),
-      "'x' should not allow multiple selection"
+    tm_g_bivariate(
+      "a label",
+      x,
+      x
     ),
-    threshold = logger::FATAL,
-    namespace = "teal.modules.general"
-  )
-})
-
-testthat::test_that("assert_single_selection succeeds when multiple selection is disabled", {
-  mock_spec <- data_extract_spec(
-    dataname = "ADSL",
-    select = teal.transform::select_spec(
-      choices = c("USUBJID", "AGE"),
-      multiple = FALSE
-    )
+    "'x' should not allow multiple selection"
   )
 
-  # Suppress logger messages
-  logger::with_log_threshold(
-    testthat::expect_s3_class(
-      tm_g_bivariate(
-        "a label",
-        mock_spec,
-        mock_spec
-      ),
-      "teal_module"
+  testthat::expect_error(
+    tm_g_bivariate(
+      "a label",
+      list(mock_spec2, mock_spec, data_extract_spec("EMPTY")),
+      x
     ),
-    threshold = logger::FATAL,
-    namespace = "teal.modules.general"
+    "'x' should not allow multiple selection"
   )
 })