We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{logger}
Current version of master from the {logger} package breaks an example on {teal.logger}. (this was detected by {verdepcheck})
master
{teal.logger}
{verdepcheck
Upstream issue daroczig/logger#120 and PR: daroczig/logger#121 daroczig/logger#125
The problem is that logger::log_appender determines the function name on Sys.call() and mapply doesn't use a direct call.
logger::log_appender
Sys.call()
mapply
I've submitted a PR upstream that would solve this. If it doesn't go ahead we can mitigate this by using the trick below:
diff --git a/R/supress_logs.R b/R/supress_logs.R index 4291111..5127d2f 100644 --- a/R/supress_logs.R +++ b/R/supress_logs.R @@ -17,6 +17,8 @@ suppress_logs <- function() { old_log_appenders <- lapply(logger::log_namespaces(), function(ns) logger::log_appender(namespace = ns)) old_log_namespaces <- logger::log_namespaces() logger::log_appender(logger::appender_file(nullfile()), namespace = logger::log_namespaces()) - withr::defer_parent(mapply(logger::log_appender, old_log_appenders, old_log_namespaces)) + + log_appender <- function(appender, namespace) logger::log_appender(appender, namespace) + withr::defer_parent(mapply(log_appender, old_log_appenders, old_log_namespaces)) invisible(NULL) }
No response
The text was updated successfully, but these errors were encountered:
This was solved upstream! 🎉
max strategy on {verdepcheck} has now passed on the automated workflow.
max
{verdepcheck}
Sorry, something went wrong.
No branches or pull requests
What happened?
Current version of
master
from the{logger}
package breaks an example on{teal.logger}
. (this was detected by{verdepcheck
})Upstream issue daroczig/logger#120 and PR:
daroczig/logger#121daroczig/logger#125The problem is that
logger::log_appender
determines the function name onSys.call()
andmapply
doesn't use a direct call.I've submitted a PR upstream that would solve this. If it doesn't go ahead we can mitigate this by using the trick below:
sessionInfo()
No response
Relevant log output
No response
Code of Conduct
Contribution Guidelines
Security Policy
The text was updated successfully, but these errors were encountered: