Skip to content

Commit 22134ab

Browse files
averissimom7pr
andauthored
Adds min package version (#286)
WIP :: parent issue: insightsengineering/nestdevs-tasks#7 Supersede: - #278 ### 🔴 Checklist for PR Reviewer - [ ] Tag yourself next to this repo on insightsengineering/nestdevs-tasks#7 - [x] Package versions are the same or higher than `main` - [x] Package list is the same - Only exception is `rmarkdown` (may have been removed on `Suggests`) - [x] All packages in `Imports`, `Depends` & `Suggests` are in new section `Config/Needs/verdepcheck` - [x] Added entry to `NEWS.md` - [x] Last `scheduled.yaml` action was run succesfully _(all 4 strategies)_ - important: it's not the last commit, it's the one that runs 4 `Scheduled 🕰️ / Dependency` actions - [x] `scheduled.yaml` SHOULD NOT have any push on any branches ### 🔴 What's needed before merging? This PR depends on some upstream changes that need to be finalized/merged before being ready to review. #### Change in code * `verdepcheck.yml` action (see comments) - [x] Remove `on: push` section - [x] Change branch to main #### PRS - [x] verdepcheck * insightsengineering/verdepcheck#24 * insightsengineering/verdepcheck#26 - [x] verdepcheck-action * insightsengineering/r-verdepcheck-action#16 ### Changes description * Adds minimum version for packages `DESCRIPTION` * Adds `Config/Need/verdepcheck` section in `DESCRIPTION` * Updates verdepcheck action --------- Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com> Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
1 parent e64b270 commit 22134ab

File tree

3 files changed

+31
-13
lines changed

3 files changed

+31
-13
lines changed

.github/workflows/scheduled.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
strategy:
1212
fail-fast: false
1313
matrix:
14-
test-strategy: ["min", "release", "max"]
14+
test-strategy: ["min_cohort", "min_isolated", "release", "max"]
1515
uses: insightsengineering/r.pkg.template/.github/workflows/verdepcheck.yaml@main
1616
name: Dependency Test - ${{ matrix.test-strategy }} 🔢
1717
secrets:

DESCRIPTION

Lines changed: 27 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,26 +17,41 @@ License: Apache License 2.0 | file LICENSE
1717
Depends:
1818
R (>= 3.6)
1919
Imports:
20-
checkmate,
20+
checkmate (>= 2.1.0),
2121
dplyr (>= 1.1.2),
22-
lifecycle,
23-
lubridate,
24-
magrittr,
25-
rlang,
26-
stringr,
27-
tibble,
28-
tidyr,
29-
yaml
22+
lifecycle (>= 1.0.3),
23+
lubridate (>= 1.7.10),
24+
magrittr (>= 1.5),
25+
rlang (>= 1.1.0),
26+
stringr (>= 1.4.1),
27+
tibble (>= 3.2.1),
28+
tidyr (>= 1.1.4),
29+
yaml (>= 2.1.19)
3030
Suggests:
3131
diffdf,
32-
knitr,
33-
rmarkdown,
34-
testthat (>= 3.0)
32+
knitr (>= 1.42),
33+
rmarkdown (>= 2.19),
34+
testthat (>= 3.0.4)
3535
VignetteBuilder:
3636
knitr
3737
RdMacros:
3838
lifecycle
3939
Config/Needs/website: insightsengineering/nesttemplate
40+
Config/Needs/verdepcheck:
41+
mllg/checkmate,
42+
tidyverse/dplyr,
43+
r-lib/lifecycle,
44+
tidyverse/lubridate,
45+
tidyverse/magrittr,
46+
r-lib/rlang,
47+
tidyverse/stringr,
48+
tidyverse/tibble,
49+
tidyverse/tidyr,
50+
yaml=vubiostat/r-yaml,
51+
gowerc/diffdf,
52+
yihui/knitr,
53+
rstudio/rmarkdown,
54+
r-lib/testthat
4055
Config/testthat/edition: 3
4156
Encoding: UTF-8
4257
Language: en-US

NEWS.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
### Enhancements
77
* Updated level of `ETHNIC` variable in all datasets from `" NOT REPORTED"` to `"NOT REPORTED"`.
88

9+
### Miscellaneous
10+
* Specified minimal version of package dependencies.
11+
912
# random.cdisc.data 0.3.14
1013

1114
### Breaking changes

0 commit comments

Comments
 (0)