Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aggregate_contiguous #247

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Fix aggregate_contiguous #247

merged 2 commits into from
Jan 12, 2024

Conversation

gsarti
Copy link
Member

@gsarti gsarti commented Jan 12, 2024

Description

Fixes the aggregate_contiguous function used by ContiguousSpanAggregator and SubwordAggregator classes in the edge case of single-step generation described by #246. Also adjusts the function behavior to avoid unnecessary transpositions and squeeze/unsqueeze operations whenever possible.

@gsarti gsarti added the bug Something isn't working label Jan 12, 2024
@gsarti gsarti mentioned this pull request Jan 12, 2024
Closed
@gsarti gsarti linked an issue Jan 12, 2024 that may be closed by this pull request
Producing heatmap visualizations with SubwordAggregator and SequenceAttributionAggregator #246
Closed
@gsarti gsarti merged commit 7503576 into main Jan 12, 2024
3 checks passed
@gsarti gsarti deleted the fix-span-aggregation branch January 12, 2024 17:08
gsarti added a commit that referenced this pull request Jan 13, 2024
@gsarti
Merge remote-tracking branch 'origin' into speed-mem-opt
62df8e3 
* origin:
  Fix `aggregate_contiguous` (#247)
  `attribute-context` CLI command (#237)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Producing heatmap visualizations with SubwordAggregator and SequenceAttributionAggregator
1 participant
@gsarti