Skip to content

JCL-394: Issued At javadoc #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
acoburn merged 2 commits into from
Jul 6, 2023
Merged

JCL-394: Issued At javadoc #573

acoburn merged 2 commits into from
Jul 6, 2023

Conversation

@acoburn
Copy link
Collaborator

@acoburn acoburn commented Jul 3, 2023

The issuance date is already supported by AccessCredential subtypes, but the base class is missing a javadoc.

@acoburn acoburn requested a review from a team as a code owner July 3, 2023 20:38
@timea-solid
Copy link
Contributor

timea-solid commented Jul 4, 2023

I saw this part of the issuance date.
But isn't the issue(..) method supposed to have a final Instant issuanceDate in its call such that the request, for example, can be requested for a future date?

@acoburn acoburn enabled auto-merge (squash) July 6, 2023 14:42
@acoburn acoburn merged commit 894e8ce into main Jul 6, 2023
@acoburn acoburn deleted the JCL-394-issuance-date branch July 6, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NSeydoux NSeydoux NSeydoux approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@acoburn @timea-solid @NSeydoux