Skip to content

fix: extend default timeout to 5 minutes #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

fix: extend default timeout to 5 minutes #683

merged 1 commit into from
Apr 16, 2025

Conversation

rsporny
Copy link
Collaborator

@rsporny rsporny commented Apr 16, 2025

Refs: ETCM-9741

@rsporny rsporny requested review from LGLO, jankun4, AmbientTea and kpinter-iohk and removed request for LGLO and jankun4 April 16, 2025 10:46
LGLO
LGLO approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@LGLO LGLO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually 5 minutes is 59 retries, because the first try is not a retry.

@rsporny rsporny force-pushed the etcm-9741-default-timeout branch 2 times, most recently from 9868ce9 to 27a9b91 Compare April 16, 2025 10:51
@rsporny rsporny force-pushed the etcm-9741-default-timeout branch from 27a9b91 to 9f36c37 Compare April 16, 2025 10:53
@rsporny rsporny changed the title fix: extend default timeout to 5 minutest fix: extend default timeout to 5 minutes Apr 16, 2025
@rsporny rsporny force-pushed the etcm-9741-default-timeout branch from 9f36c37 to 674b9be Compare April 16, 2025 10:56
@rsporny rsporny enabled auto-merge (squash) April 16, 2025 10:57
@rsporny rsporny force-pushed the etcm-9741-default-timeout branch from 674b9be to 50fe1f3 Compare April 16, 2025 11:19
@rsporny rsporny merged commit 54dd081 into master Apr 16, 2025
26 checks passed
@rsporny rsporny deleted the etcm-9741-default-timeout branch April 16, 2025 11:39
rsporny added a commit that referenced this pull request Apr 16, 2025
@rsporny
fix: extend default timeout to 5 minutes (#683)
378ff4a 
Refs: ETCM-9741
rsporny added a commit that referenced this pull request Apr 22, 2025
@rsporny
fix: extend default timeout to 5 minutes (#683)
e0271cd 
Refs: ETCM-9741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilligan gilligan gilligan approved these changes

@LGLO LGLO LGLO approved these changes

@AmbientTea AmbientTea Awaiting requested review from AmbientTea

@kpinter-iohk kpinter-iohk Awaiting requested review from kpinter-iohk

@jankun4 jankun4 Awaiting requested review from jankun4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsporny @gilligan @LGLO