-
Notifications
You must be signed in to change notification settings - Fork 44
fix: missing 00000
immutable files with Cardano DB v2
#2520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In artifact built for Cardano database v2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures the 00000
immutable file is included when embedding and downloading Cardano DB snapshots by updating start indices and related tests.
- Start immutable file ranges from 0 instead of 1 in client and aggregator code
- Adjust loops, tests, and expectations to include file number
00000
- Bump
mithril-client
andmithril-aggregator
crate versions
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
mithril-client/src/cardano_database_client/immutable_file_range.rs | Change FIRST_IMMUTABLE_FILE_NUMBER from 1 to 0 |
mithril-client/Cargo.toml | Bump version to 0.12.8 |
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/immutable.rs | Introduce FIRST_IMMUTABLE_FILE_NUMBER=0 , update loops and tests |
mithril-aggregator/src/artifact_builder/cardano_database.rs | Adjust loaded immutable file count (+1) |
mithril-aggregator/Cargo.toml | Bump version to 0.7.54 |
mithril-aggregator/src/artifact_builder/cardano_database_artifacts/immutable.rs
Show resolved
Hide resolved
c579e36
to
2338124
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think you can simplify the tests by shifting the previous upper bound immutable to keep the same number of checks.
For Cardano DB v2 restoration.
* mithril-aggregator from `0.7.53` to `0.7.54` * mithril-client from `0.12.7` to `0.12.8`
2338124
to
9a5e305
Compare
Content
This PR includes a fix on Cardano DB v2 which can not restore a valid full Cardano database:
00000
immutable files in the snapshot archive files00000
immutable files in the clientPre-submit checklist
Issue(s)
Closes #2519